From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
drbd-user@lists.linbit.com
Subject: Re: [DRBD-user] [patch -resend] drbd: fix resync_dump_detail() output
Date: Fri, 08 Jun 2012 18:50:08 +0000 [thread overview]
Message-ID: <20120608185008.GC8030@soda.linbit> (raw)
In-Reply-To: <20120608123128.GA18293@elgon.mountain>
On Fri, Jun 08, 2012 at 03:31:28PM +0300, Dan Carpenter wrote:
> The tests here aren't correct. It should be doing a shift before doing
> the bitwise AND. (bme->flags & BME_NO_WRITES) is always false and
> (bme->flags & BME_LOCKED) checks for BME_NO_WRITES instead of checking
> for locked.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Ack.
> ---
> I sent this to the drbd-user list in March, but never recieved a
> response.
Sorry, seems to have been lost :-(
Lars
> diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
> index 2959cdf..ffe1ee4 100644
> --- a/drivers/block/drbd/drbd_proc.c
> +++ b/drivers/block/drbd/drbd_proc.c
> @@ -187,8 +187,10 @@ static void resync_dump_detail(struct seq_file *seq, struct lc_element *e)
> struct bm_extent *bme = lc_entry(e, struct bm_extent, lce);
>
> seq_printf(seq, "%5d %s %s\n", bme->rs_left,
> - bme->flags & BME_NO_WRITES ? "NO_WRITES" : "---------",
> - bme->flags & BME_LOCKED ? "LOCKED" : "------"
> + test_bit(BME_NO_WRITES, &bme->flags) ?
> + "NO_WRITES" : "---------",
> + test_bit(BME_LOCKED, &bme->flags) ?
> + "LOCKED" : "------"
> );
> }
--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
next prev parent reply other threads:[~2012-06-08 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 12:31 [patch -resend] drbd: fix resync_dump_detail() output Dan Carpenter
2012-06-08 18:50 ` Lars Ellenberg [this message]
2014-02-17 19:43 ` [DRBD-user] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608185008.GC8030@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=dan.carpenter@oracle.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).