From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Drbd-dev] [patch] drbd: potential integer overflow in receive_SyncParam()
Date: Tue, 12 Jun 2012 12:25:06 +0000 [thread overview]
Message-ID: <20120612122506.GF4069@soda.linbit> (raw)
On Tue, Jun 12, 2012 at 10:43:11AM +0300, Dan Carpenter wrote:
> I believe this comes from the network so there is a risk of integer
> overflow on 32 bit. Using kcalloc() is a little cleaner as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
> index ea4836e..1e27876 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -2902,7 +2902,7 @@ static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
>
> fifo_size = (mdev->sync_conf.c_plan_ahead * 10 * SLEEP_TIME) / HZ;
> if (fifo_size != mdev->rs_plan_s.size && fifo_size > 0) {
> - rs_plan_s = kzalloc(sizeof(int) * fifo_size, GFP_KERNEL);
> + rs_plan_s = kcalloc(fifo_size, sizeof(int), GFP_KERNEL);
> if (!rs_plan_s) {
> dev_err(DEV, "kmalloc of fifo_buffer failed");
> goto disconnect;
sync_conf.c_plan_ahead is capped at 300 by drbdsetup.
But yes, since this is not enforced in kernel code,
your fix is correct.
Lars
reply other threads:[~2012-06-12 12:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612122506.GF4069@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox