Re: [patch] eCryptfs: fix ecryptfs_privileged_open() for read only files

Dan Carpenter
2012-06-12T19:17:27Z

On Tue, Jun 12, 2012 at 12:02:47PM -0700, Tyler Hicks wrote:
> On 2012-06-09 12:11:29, Dan Carpenter wrote:
> > The intent here is to handle read only opens differently. For example,
> > if we don't want to create the file if it doesn't exist. The problem
> > here is that O_RDONLY is 0 and if (x & 0) {... is always false.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks, Dan! I committed a slightly different fix with more context in
> the commit message (because I had to remind myself what was going on
> with that conditional in the first place).
>
> http://git.kernel.org/?p=linux/kernel/git/tyhicks/ecryptfs.git;a=commitdiff;h‘425d9b57c024bf8b28055b6a480809fe0941ee
>

Looks good.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html