From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] eCryptfs: fix ecryptfs_privileged_open() for read only files
Date: Tue, 12 Jun 2012 19:17:27 +0000 [thread overview]
Message-ID: <20120612191622.GO13539@mwanda> (raw)
In-Reply-To: <20120609091129.GD877@elgon.mountain>
On Tue, Jun 12, 2012 at 12:02:47PM -0700, Tyler Hicks wrote:
> On 2012-06-09 12:11:29, Dan Carpenter wrote:
> > The intent here is to handle read only opens differently. For example,
> > if we don't want to create the file if it doesn't exist. The problem
> > here is that O_RDONLY is 0 and if (x & 0) {... is always false.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks, Dan! I committed a slightly different fix with more context in
> the commit message (because I had to remind myself what was going on
> with that conditional in the first place).
>
> http://git.kernel.org/?p=linux/kernel/git/tyhicks/ecryptfs.git;a=commitdiff;h‘425d9b57c024bf8b28055b6a480809fe0941ee
>
Looks good.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-06-12 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 9:11 [patch] eCryptfs: fix ecryptfs_privileged_open() for read only files Dan Carpenter
2012-06-12 19:02 ` Tyler Hicks
2012-06-12 19:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612191622.GO13539@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox