public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: wfg@linux.intel.com
To: kernel-janitors@vger.kernel.org
Subject: [tip:perf/core 86/90] arch/x86/kernel/cpu/perf_event.h:377:43: sparse: dubious one-bit signed bitfie
Date: Fri, 06 Jul 2012 17:52:21 +0000	[thread overview]
Message-ID: <20120706175221.GA22130@localhost> (raw)

Hi Peter,

Should we make the bits "unsigned"?

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
head:   6a67943a18c264d5f3df436da38edb3e59adc905
commit: 3e0091e2b6f8cd59e567f247e345a3a6ad1f6e7e [86/90] perf/x86: Save a few bytes in 'struct x86_pmu'

All sparse warnings:

+ arch/x86/kernel/cpu/perf_event.h:377:43: sparse: dubious one-bit signed bitfield
  arch/x86/kernel/cpu/perf_event.h:378:43: sparse: dubious one-bit signed bitfield
  arch/x86/kernel/cpu/perf_event.h:379:43: sparse: dubious one-bit signed bitfield
  arch/x86/kernel/cpu/perf_event.h:380:43: sparse: dubious one-bit signed bitfield
  arch/x86/kernel/cpu/perf_event.h:381:43: sparse: dubious one-bit signed bitfield

vim +377 arch/x86/kernel/cpu/perf_event.h
   374		/*
   375		 * Intel DebugStore bits
   376		 */
 > 377		int		bts		:1,
   378				bts_active	:1,
   379				pebs		:1,
   380				pebs_active	:1,

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

             reply	other threads:[~2012-07-06 17:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06 17:52 wfg [this message]
2012-07-09 11:52 ` [tip:perf/core 86/90] arch/x86/kernel/cpu/perf_event.h:377:43: sparse: dubious one-bit signed bi Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706175221.GA22130@localhost \
    --to=wfg@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox