public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: wfg@linux.intel.com
To: kernel-janitors@vger.kernel.org
Subject: [mfd:for-next 39/66] drivers/extcon/extcon-max8997.c:436:6: warning: 'ret' may be used uninitialized
Date: Mon, 09 Jul 2012 02:28:35 +0000	[thread overview]
Message-ID: <20120709022835.GA9344@localhost> (raw)

Hi Chanwoo,

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
head:   c6a5d9ff6f96128161126c0a01f0a28edf8010da
commit: dca1a71e4108a0a9051a653d885297e9d1cc656c [39/66] extcon: Add support irq domain for MAX8997 muic

All warnings:

drivers/extcon/extcon-max8997.c: In function 'max8997_muic_probe':
drivers/extcon/extcon-max8997.c:436:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

vim +436 drivers/extcon/extcon-max8997.c
   433		struct max8997_dev *max8997 = dev_get_drvdata(pdev->dev.parent);
   434		struct max8997_platform_data *pdata = dev_get_platdata(max8997->dev);
   435		struct max8997_muic_info *info;
 > 436		int ret, i;
   437	
   438		info = kzalloc(sizeof(struct max8997_muic_info), GFP_KERNEL);
   439		if (!info) {

'ret' is uninitialized in this branch:

+               virq = irq_create_mapping(max8997->irq_domain, muic_irq->irq);
+               if (!virq)
+                       goto err_irq;

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

                 reply	other threads:[~2012-07-09  2:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120709022835.GA9344@localhost \
    --to=wfg@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox