From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [staging:staging-next 93/99] drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: data definition
Date: Thu, 12 Jul 2012 08:02:36 +0000 [thread overview]
Message-ID: <20120712080235.GD6056@mwanda> (raw)
In-Reply-To: <20120712063936.GA8979@localhost>
On Thu, Jul 12, 2012 at 01:18:10PM +0545, devendra.aaru wrote:
> On Thu, Jul 12, 2012 at 12:24 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> > vim +1061 drivers/staging/sm7xxfb/sm7xxfb.c
> > 1058 .driver.pm = SM7XX_PM_OPS,
> > 1059 };
> > 1060
> >> 1061 module_pci_driver(smtcfb_driver);
> > 1062
> > 1063 MODULE_AUTHOR("Siliconmotion ");
> > 1064 MODULE_DESCRIPTION("Framebuffer driver for SMI Graphic Cards");
> >
> Hello,
> I think CONFIG_PCI is set to n. so that we got this warnings.
> In Kconfig of drivers/staging/sm7xxfb if we set depends on FB &&
> PCI solves this problem oneway.
> But i m really not-sure about if this is the valid fix.
>
Depends on PCI is correct. Send a patch.
regards,
dan carpenter
prev parent reply other threads:[~2012-07-12 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 6:39 [staging:staging-next 93/99] drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: data definition has Fengguang Wu
2012-07-12 7:51 ` [staging:staging-next 93/99] drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: data definition devendra.aaru
2012-07-12 8:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712080235.GD6056@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox