From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Date: Fri, 13 Jul 2012 08:37:19 +0000 Subject: Re: [nf-next:mmap-netlink 65/68] net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variab Message-Id: <20120713083719.GC9927@breakpoint.cc> List-Id: References: <20120712235145.GD5608@localhost> In-Reply-To: <20120712235145.GD5608@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Fengguang Wu wrote: > tree: git://150.214.188.80/nf-next mmap-netlink > head: c7e7243d0b69e2323dde057c28f1102d00e5a3c6 > commit: b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 [65/68] nfqueue: extend spinlocked section for mmap'd sockets > > All warnings: > > net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_enqueue_packet': > net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable 'size' [-Wunused-variable] Thanks for reporting. Pablo, please consider squashing this in with the original patch before submitting for inclusion: From: Florian Westphal Date: Fri, 13 Jul 2012 09:59:30 +0200 Subject: [PATCH] netfilter: nf_queue: kill unused variable In function 'nfqnl_enqueue_packet': warning: unused variable 'size' [-Wunused-variable] caused by commit b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 (nfqueue: extend spinlocked section for mmap'd sockets) Reported-by: Fengguang Wu Signed-off-by: Florian Westphal --- net/netfilter/nfnetlink_queue_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c index 82bcced..09c85d0 100644 --- a/net/netfilter/nfnetlink_queue_core.c +++ b/net/netfilter/nfnetlink_queue_core.c @@ -404,7 +404,7 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum) int err = -ENOBUFS; int failopen = 0; struct sk_buff *entskb = entry->skb; - size_t data_len = 0, size; + size_t data_len = 0; /* rcu_read_lock()ed by nf_hook_slow() */ queue = instance_lookup(queuenum); -- 1.7.3.4