public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [modsign:modsign 12/27] sparse: symbol 'pgp_pubkey_hash' was not declared. Should it be static?
Date: Wed, 18 Jul 2012 13:54:47 +0000	[thread overview]
Message-ID: <20120718135447.GA8256@localhost> (raw)

Hi David,

There are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-modsign.git modsign
head:   84d2387379da278fa8e8639e37125c72f930743a
commit: 4f49a5fc6553686e5cb8cc6f09f9342307d2fe07 [12/27] KEYS: PGP-based public key signature verification

All sparse warnings:

+ security/keys/crypto/pgp_sig_verify.c:23:3: sparse: symbol 'pgp_pubkey_hash' was not declared. Should it be static?

vim +23 security/keys/crypto/pgp_sig_verify.c
    20	
    21	const struct {
    22		enum pkey_hash_algo algo : 8;
  > 23	} pgp_pubkey_hash[PGP_HASH__LAST] = {
    24		[PGP_HASH_MD5].algo		= PKEY_HASH_MD5,
    25		[PGP_HASH_SHA1].algo		= PKEY_HASH_SHA1,
    26		[PGP_HASH_RIPE_MD_160].algo	= PKEY_HASH_RIPE_MD_160,

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

                 reply	other threads:[~2012-07-18 13:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120718135447.GA8256@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox