public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [wireless-next:for-davem 87/99] net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (diff
Date: Thu, 19 Jul 2012 03:12:53 +0000	[thread overview]
Message-ID: <20120719031253.GA8922@localhost> (raw)

Hi Saurabh,

There are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git for-davem
head:   ddbe503203855939946430e39bae58de11b70b69
commit: 1181412c1a671ed4e8fb1736f17e6ec617c68059 [87/99] net/ipv4: VTI support new module for ip_vti.

All sparse warnings:

+ net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (different address spaces)
  net/ipv4/ip_vti.c:193:17:    expected struct ip_tunnel [noderef] <asn:4>**tp
  net/ipv4/ip_vti.c:193:17:    got struct ip_tunnel **
+ net/ipv4/ip_vti.c:205:49: sparse: incorrect type in initializer (different address spaces)
  net/ipv4/ip_vti.c:205:49:    expected struct ip_tunnel [noderef] <asn:4>**tp
  net/ipv4/ip_vti.c:205:49:    got struct ip_tunnel **
  net/ipv4/ip_vti.c:223:17: sparse: incorrect type in assignment (different address spaces)
  net/ipv4/ip_vti.c:223:17:    expected struct ip_tunnel [noderef] <asn:4>**tp
  net/ipv4/ip_vti.c:223:17:    got struct ip_tunnel **
+ net/ipv4/ip_vti.c:693:29: sparse: incompatible types in comparison expression (different address spaces)

vim +193 net/ipv4/ip_vti.c
   190		struct ip_tunnel __rcu **tp;
   191		struct ip_tunnel *iter;
   192	
 > 193		for (tp = vti_bucket(ipn, t);
   194		     (iter = rtnl_dereference(*tp)) != NULL;
   195		     tp = &iter->next) {
   196			if (t = iter) {

Which can be fixed by adding some rcu_*() accessors to the RCU
protected pointers.

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

             reply	other threads:[~2012-07-19  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19  3:12 Fengguang Wu [this message]
2012-07-19  5:06 ` [wireless-next:for-davem 87/99] net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment ( Saurabh Mohan
2012-07-19  5:38 ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120719031253.GA8922@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox