From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [rcu:rcu:smp:hotplug 3/6] softirq.c:(.init.text+0x540): undefined reference to `smpboot_register
Date: Sat, 21 Jul 2012 21:06:52 +0000 [thread overview]
Message-ID: <20120721210652.GA5596@localhost> (raw)
In-Reply-To: <500aeafe.TGJ6m5FSx2bYXZFx%fengguang.wu@intel.com>
> > kernel/built-in.o: In function `spawn_ksoftirqd':
> > softirq.c:(.init.text+0x540): undefined reference to `smpboot_register_percpu_thread'
>
> Hello, Fengguang,
>
> Does the following patch help?
Yeah, it helps!
Thanks,
Fengguang
> ------------------------------------------------------------------------
>
>
> hotplug: Fix UP bug in smpboot hotplug code
>
> Because kernel subsystems need their per-CPU kthreads on UP systems
> as well as on SMP systems, the smpboot hotplug kthread functions
> must be provided in UP builds as well as in SMP builds. This commit
> therefore adds smpboot.c to UP builds and excludes irrelevant code
> via #ifdef.
>
> Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index c0cc67a..e5602d3 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -10,7 +10,7 @@ obj-y = fork.o exec_domain.o panic.o printk.o \
> kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o \
> hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \
> notifier.o ksysfs.o cred.o \
> - async.o range.o groups.o lglock.o
> + async.o range.o groups.o lglock.o smpboot.o
>
> ifdef CONFIG_FUNCTION_TRACER
> # Do not trace debug files and internal ftrace files
> @@ -46,7 +46,6 @@ obj-$(CONFIG_DEBUG_RT_MUTEXES) += rtmutex-debug.o
> obj-$(CONFIG_RT_MUTEX_TESTER) += rtmutex-tester.o
> obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o
> obj-$(CONFIG_SMP) += smp.o
> -obj-$(CONFIG_SMP) += smpboot.o
> ifneq ($(CONFIG_SMP),y)
> obj-y += up.o
> endif
> diff --git a/kernel/smpboot.c b/kernel/smpboot.c
> index e17653d..6b0d6fe 100644
> --- a/kernel/smpboot.c
> +++ b/kernel/smpboot.c
> @@ -15,6 +15,8 @@
>
> #include "smpboot.h"
>
> +#ifdef CONFIG_SMP
> +
> #ifdef CONFIG_GENERIC_SMP_IDLE_THREAD
> /*
> * For the hotplug case we keep the task structs around and reuse
> @@ -67,6 +69,8 @@ void __init idle_threads_init(void)
> }
> #endif
>
> +#endif /* #ifdef CONFIG_SMP */
> +
> static LIST_HEAD(hotplug_threads);
> static DEFINE_MUTEX(smpboot_threads_lock);
>
prev parent reply other threads:[~2012-07-21 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 17:46 [rcu:rcu:smp:hotplug 3/6] softirq.c:(.init.text+0x540): undefined reference to `smpboot_register_per Fengguang Wu
2012-07-21 18:27 ` [rcu:rcu:smp:hotplug 3/6] softirq.c:(.init.text+0x540): undefined reference to `smpboot_register Paul E. McKenney
2012-07-21 21:06 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120721210652.GA5596@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox