From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Date: Sat, 28 Jul 2012 12:43:57 +0000 Subject: [PATCH] pch_uart: check kzalloc result in dma_handle_tx() Message-Id: <20120728124357.GA13192@localhost> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomoya MORINAGA Cc: Alan Cox , Greg Kroah-Hartman , linux-serial@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Reported by coccinelle: drivers/tty/serial/pch_uart.c:979:1-14: alloc with no test, possible model on line 994 Signed-off-by: Fengguang Wu --- drivers/tty/serial/pch_uart.c | 4 ++++ 1 file changed, 4 insertions(+) WARNING: this may be a superficial fix! --- linux.orig/drivers/tty/serial/pch_uart.c 2012-06-07 05:39:57.550846385 +0800 +++ linux/drivers/tty/serial/pch_uart.c 2012-07-28 20:37:27.803145392 +0800 @@ -974,6 +974,10 @@ static unsigned int dma_handle_tx(struct priv->tx_dma_use = 1; priv->sg_tx_p = kzalloc(sizeof(struct scatterlist)*num, GFP_ATOMIC); + if (!priv->sg_tx_p) { + dev_err(priv->port.dev, "%s:kzalloc Failed\n", __func__); + return 0; + } sg_init_table(priv->sg_tx_p, num); /* Initialize SG table */ sg = priv->sg_tx_p;