kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types i
Date: Sun, 29 Jul 2012 00:48:11 +0000	[thread overview]
Message-ID: <20120729004811.GB7049@localhost> (raw)

Hi Pablo,

There are new sparse warnings show up in

tree:   git://150.214.188.80/nf-next nf_tables4
head:   b33538d5361ec09e5c947765a7615fc67640a9fe
commit: b33538d5361ec09e5c947765a7615fc67640a9fe [2/2] netfilter: nf_tables

All sparse warnings:

+ net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types in comparison expression (different address spaces)

vim +184 net/ipv4/netfilter/nf_table_nat_ipv4.c
   181		enum nf_nat_manip_type maniptype = HOOK2MANIP(ops->hooknum);
   182		unsigned int ret;
   183	
 > 184		if (ct = NULL || ct = &nf_conntrack_untracked)
   185			return NF_ACCEPT;
   186	
   187		NF_CT_ASSERT(!(ip_hdr(skb)->frag_off & htons(IP_MF | IP_OFFSET)));

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

             reply	other threads:[~2012-07-29  0:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-29  0:48 Fengguang Wu [this message]
2012-07-30  0:56 ` [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible typ Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120729004811.GB7049@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).