* [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types i
@ 2012-07-29 0:48 Fengguang Wu
2012-07-30 0:56 ` [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible typ Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-07-29 0:48 UTC (permalink / raw)
To: kernel-janitors
Hi Pablo,
There are new sparse warnings show up in
tree: git://150.214.188.80/nf-next nf_tables4
head: b33538d5361ec09e5c947765a7615fc67640a9fe
commit: b33538d5361ec09e5c947765a7615fc67640a9fe [2/2] netfilter: nf_tables
All sparse warnings:
+ net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types in comparison expression (different address spaces)
vim +184 net/ipv4/netfilter/nf_table_nat_ipv4.c
181 enum nf_nat_manip_type maniptype = HOOK2MANIP(ops->hooknum);
182 unsigned int ret;
183
> 184 if (ct = NULL || ct = &nf_conntrack_untracked)
185 return NF_ACCEPT;
186
187 NF_CT_ASSERT(!(ip_hdr(skb)->frag_off & htons(IP_MF | IP_OFFSET)));
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible typ
2012-07-29 0:48 [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types i Fengguang Wu
@ 2012-07-30 0:56 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2012-07-30 0:56 UTC (permalink / raw)
To: kernel-janitors
On Sun, Jul 29, 2012 at 08:48:11AM +0800, Fengguang Wu wrote:
> Hi Pablo,
>
> There are new sparse warnings show up in
>
> tree: git://150.214.188.80/nf-next nf_tables4
> head: b33538d5361ec09e5c947765a7615fc67640a9fe
> commit: b33538d5361ec09e5c947765a7615fc67640a9fe [2/2] netfilter: nf_tables
>
> All sparse warnings:
>
> + net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types in comparison expression (different address spaces)
>
> vim +184 net/ipv4/netfilter/nf_table_nat_ipv4.c
> 181 enum nf_nat_manip_type maniptype = HOOK2MANIP(ops->hooknum);
> 182 unsigned int ret;
> 183
> > 184 if (ct = NULL || ct = &nf_conntrack_untracked)
should be fixed now in nf_tables5 branch. Now we use
nf_ct_is_untracked(ct) instead of the reference to the global
untracked conntrack object.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-30 0:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-29 0:48 [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types i Fengguang Wu
2012-07-30 0:56 ` [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible typ Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).