From: Josef Bacik <jbacik@fusionio.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [josef-btrfs:own-caching 10/12] fs/btrfs/disk-io.c:822:5: sparse: symbol 'btrfs_wq_btree_submit_
Date: Fri, 03 Aug 2012 12:45:43 +0000 [thread overview]
Message-ID: <20120803124543.GJ2263@localhost.localdomain> (raw)
In-Reply-To: <20120803000038.GA5734@localhost>
On Thu, Aug 02, 2012 at 06:00:38PM -0600, Fengguang Wu wrote:
> Hi Josef,
>
> There are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git own-caching
> head: c7fc403528c5a40ac1dad05296ba4835072bc03d
> commit: b6579666166dc9043543fbae61ba81451aab628b [10/12] Btrfs: manage metadata cache ourselves
>
> All sparse warnings:
>
> + fs/btrfs/disk-io.c:822:5: sparse: symbol 'btrfs_wq_btree_submit_bio' was not declared. Should it be static?
> + fs/btrfs/disk-io.c:921:5: sparse: symbol 'merge_bio' was not declared. Should it be static?
> + fs/btrfs/disk-io.c:1049:5: sparse: symbol 'write_iolock_eb' was not declared. Should it be static?
> fs/btrfs/disk-io.c:2805:17: sparse: incompatible types in comparison expression (different address spaces)
> fs/btrfs/disk-io.c:2980:25: sparse: incompatible types in comparison expression (different address spaces)
>
> vim +822 fs/btrfs/disk-io.c
> 819 bio_endio(async->bio, ret);
> 820 }
> 821
> > 822 int btrfs_wq_btree_submit_bio(struct btrfs_root *root, int rw,
> 823 struct bio *bio, int mirror_num)
> 824 {
> 825 struct btrfs_fs_info *fs_info = root->fs_info;
>
> Please consider folding the attached diff :-)
Wow Fengguang you really like using the bleeding edge stuff eh? :) I've folded
this in, thanks.
Josef
next prev parent reply other threads:[~2012-08-03 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 0:00 [josef-btrfs:own-caching 10/12] fs/btrfs/disk-io.c:822:5: sparse: symbol 'btrfs_wq_btree_submit_bio' Fengguang Wu
2012-08-03 12:45 ` Josef Bacik [this message]
2012-08-03 12:51 ` [josef-btrfs:own-caching 10/12] fs/btrfs/disk-io.c:822:5: sparse: symbol 'btrfs_wq_btree_submit_ Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803124543.GJ2263@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).