From: Josef Bacik <jbacik@fusionio.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [josef-btrfs:master 9/11] fs/btrfs/delayed-inode.c:1013:1-11: second lock on line 1013
Date: Fri, 03 Aug 2012 21:11:32 +0000 [thread overview]
Message-ID: <20120803211132.GL2263@localhost.localdomain> (raw)
In-Reply-To: <20120803131659.GA20007@localhost>
On Fri, Aug 03, 2012 at 07:16:59AM -0600, Fengguang Wu wrote:
> Hi Josef,
>
> There are (old) coccinelle warnings in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master
> head: 233564d3f5bde271885f5b784b63cfe627bba0a5
> commit: ec93ee7ac77b2e95934253823918c3c684c1a36c [9/11] Btrfs: barrier before waitqueue_active
>
> All coccinelle warnings:
>
> + fs/btrfs/delayed-inode.c:1013:1-11: second lock on line 1013
> --
> + fs/btrfs/volumes.c:2888:1-3: WARNING: PTR_RET can be used (patch attached)
>
> vim +1013 fs/btrfs/delayed-inode.c
> 1010 int ret = 0;
> 1011
> 1012 do_again:
> > 1013 mutex_lock(&node->mutex);
> 1014 curr = __btrfs_first_delayed_deletion_item(node);
> 1015 if (!curr)
> 1016 goto delete_fail;
> ...
> 1031 if (curr)
> > 1032 goto do_again;
> 1033 else
> 1034 goto delete_fail;
>
Ok that wasn't related to my patch so I'm not going to fold it in, do you want
to send me a real patch with a Signed-off-by that I can apply? Thanks,
Josef
next prev parent reply other threads:[~2012-08-03 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 13:16 [josef-btrfs:master 9/11] fs/btrfs/delayed-inode.c:1013:1-11: second lock on line 1013 Fengguang Wu
2012-08-03 21:11 ` Josef Bacik [this message]
2012-08-04 7:43 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803211132.GL2263@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).