From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 10 Aug 2012 09:24:37 +0000 Subject: [patch] hwmon: (f71882fg) Signedness bug in f71882fg_init() Message-Id: <20120810092435.GC26875@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org "address" stores and unsigned short on success but a negative on failure so it needs to be an int. Signed-off-by: Dan Carpenter --- Applies to linux-next. This was introduced in 1f7f944 "hwmon: (f71882fg) Fix build warning". diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c index b6304eb..853f544 100644 --- a/drivers/hwmon/f71882fg.c +++ b/drivers/hwmon/f71882fg.c @@ -2662,7 +2662,7 @@ exit_device_put: static int __init f71882fg_init(void) { int err = -ENODEV; - unsigned short address; + int address; struct f71882fg_sio_data sio_data; memset(&sio_data, 0, sizeof(sio_data));