From mboxrd@z Thu Jan  1 00:00:00 1970
From: Guenter Roeck <linux@roeck-us.net>
Date: Fri, 10 Aug 2012 18:44:32 +0000
Subject: Re: [patch] hwmon: (sch56xx-common) signedness bug in sch56xx_init()
Message-Id: <20120810184432.GB4625@roeck-us.net>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20120810092412.GB26875@elgon.mountain>
In-Reply-To: <20120810092412.GB26875@elgon.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On Fri, Aug 10, 2012 at 12:24:13PM +0300, Dan Carpenter wrote:
> "address" is used to store an unsigned short on success but a negative
> error code on failure.  It needs to be an int for the error handling to
> work.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch merged into the original patch which introduced the problem.

Thanks,
Guenter

> ---
> This is for linux-next.  The bug was introduced in 1645e4fc "hwmon:
> (sch56xx-common) Fix build warnings"
> 
> diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
> index 69abbf7..c93061f5 100644
> --- a/drivers/hwmon/sch56xx-common.c
> +++ b/drivers/hwmon/sch56xx-common.c
> @@ -594,7 +594,7 @@ exit_device_put:
>  
>  static int __init sch56xx_init(void)
>  {
> -	unsigned short address;
> +	int address;
>  	const char *name = NULL;
>  
>  	address = sch56xx_find(0x4e, &name);
>