From: Guenter Roeck <linux@roeck-us.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] hwmon: (f71882fg) Signedness bug in f71882fg_init()
Date: Fri, 10 Aug 2012 18:45:07 +0000 [thread overview]
Message-ID: <20120810184507.GC4625@roeck-us.net> (raw)
In-Reply-To: <20120810092435.GC26875@elgon.mountain>
On Fri, Aug 10, 2012 at 12:24:37PM +0300, Dan Carpenter wrote:
> "address" stores and unsigned short on success but a negative on failure
> so it needs to be an int.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch merged into the original patch introducing the problem.
Thanks,
Guenter
> ---
> Applies to linux-next. This was introduced in 1f7f944 "hwmon:
> (f71882fg) Fix build warning".
>
> diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> index b6304eb..853f544 100644
> --- a/drivers/hwmon/f71882fg.c
> +++ b/drivers/hwmon/f71882fg.c
> @@ -2662,7 +2662,7 @@ exit_device_put:
> static int __init f71882fg_init(void)
> {
> int err = -ENODEV;
> - unsigned short address;
> + int address;
> struct f71882fg_sio_data sio_data;
>
> memset(&sio_data, 0, sizeof(sio_data));
>
prev parent reply other threads:[~2012-08-10 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 9:24 [patch] hwmon: (f71882fg) Signedness bug in f71882fg_init() Dan Carpenter
2012-08-10 18:45 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810184507.GC4625@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox