Re: [trace:rfc:multi-buffers-v4 23/26] kernel/trace/trace_mmiotrace.c:333:33: error: incompatible ty

Re: [trace:rfc:multi-buffers-v4 23/26] kernel/trace/trace_mmiotrace.c:333:33: error: incompatible ty

[Steven Rostedt]

On Tue, 2012-08-14 at 03:16 +0800, Fengguang Wu wrote:
> Hi Steven,

Hi Fengguang, Please email to my rostedt@goodmis.org account. You might
want to remove this one from you address book. Or is this email
automated and uses the 'author' tag? If so, can you add aliases to your
scripts and replace this email with my other account?

> 
> FYI, kernel build failed on
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git rfc/multi-buffers-v4
> head:   e712fa131ebb7d79ffb4965b6ac5493408662b26
> commit: f46d90989f7d8a90193391899b9f5b6242527f0f [23/26] tracing: Replace the static global per_cpu arrays with allocated per_cpu
> config: x86_64-allyesdebian (attached as .config)
> 
> All related error/warning messages:
> 
> kernel/trace/trace_mmiotrace.c: In function 'mmio_trace_rw':
> kernel/trace/trace_mmiotrace.c:333:33: error: incompatible types when initializing type 'struct trace_array_cpu *' using type 'struct trace_array_cpu'
> kernel/trace/trace_mmiotrace.c: In function 'mmio_trace_mapping':
> kernel/trace/trace_mmiotrace.c:366:7: error: incompatible types when assigning to type 'struct trace_array_cpu *' from type 'struct trace_array_cpu'
> 
> vim +333 kernel/trace/trace_mmiotrace.c
>    330	void mmio_trace_rw(struct mmiotrace_rw *rw)
>    331	{
>    332		struct trace_array *tr = mmio_trace_array;
>  > 333		struct trace_array_cpu *data = tr->data[smp_processor_id()];
>    334		__trace_mmiotrace_rw(tr, data, rw);
>    335	}
>    336	

Thanks for the info. I probably would have caught this in my own tests,
but this was an RFC branch that someone asked me to upload. Do you
automate all recent branches to kernel.org?

-- Steve

Re: [trace:rfc:multi-buffers-v4 23/26] kernel/trace/trace_mmiotrace.c:333:33: error: incompatible ty

[Fengguang Wu]

On Mon, Aug 13, 2012 at 03:53:14PM -0400, Steven Rostedt wrote:
> On Tue, 2012-08-14 at 03:16 +0800, Fengguang Wu wrote:
> > Hi Steven,
> 
> Hi Fengguang, Please email to my rostedt@goodmis.org account. You might
> want to remove this one from you address book. Or is this email
> automated and uses the 'author' tag? If so, can you add aliases to your
> scripts and replace this email with my other account?

Steven, I'm so sorry! It's probably the third time I get your address
wrong! This time it's due to the script automatically extracting the
email address from the git commit. I'll fix it with an alias.

> > 
> > FYI, kernel build failed on
> > 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git rfc/multi-buffers-v4
> > head:   e712fa131ebb7d79ffb4965b6ac5493408662b26
> > commit: f46d90989f7d8a90193391899b9f5b6242527f0f [23/26] tracing: Replace the static global per_cpu arrays with allocated per_cpu
> > config: x86_64-allyesdebian (attached as .config)
> > 
> > All related error/warning messages:
> > 
> > kernel/trace/trace_mmiotrace.c: In function 'mmio_trace_rw':
> > kernel/trace/trace_mmiotrace.c:333:33: error: incompatible types when initializing type 'struct trace_array_cpu *' using type 'struct trace_array_cpu'
> > kernel/trace/trace_mmiotrace.c: In function 'mmio_trace_mapping':
> > kernel/trace/trace_mmiotrace.c:366:7: error: incompatible types when assigning to type 'struct trace_array_cpu *' from type 'struct trace_array_cpu'
> > 
> > vim +333 kernel/trace/trace_mmiotrace.c
> >    330	void mmio_trace_rw(struct mmiotrace_rw *rw)
> >    331	{
> >    332		struct trace_array *tr = mmio_trace_array;
> >  > 333		struct trace_array_cpu *data = tr->data[smp_processor_id()];
> >    334		__trace_mmiotrace_rw(tr, data, rw);
> >    335	}
> >    336	
> 
> Thanks for the info. I probably would have caught this in my own tests,
> but this was an RFC branch that someone asked me to upload. Do you
> automate all recent branches to kernel.org?

Yes. By default, all commits in all branches are tested in the
monitored git trees. But in case one branch is not ready for testing,
you may add a line

Dont-Auto-Build

in any commit of the branch. Then my script will grep it and skip the
whole branch.

Or you may provide a regex pattern of branch names to auto blacklist
in future.

Thanks,
Fengguang