From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: xgifb: fix bitwise vs logical bug
Date: Tue, 14 Aug 2012 10:45:20 +0000 [thread overview]
Message-ID: <201208141245.21045.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20120814070445.GF4791@elgon.mountain>
Am Dienstag, 14. August 2012, 09:04:45 schrieb Dan Carpenter:
> This is a static checker fix and not something I can test. The intent
> of the code here is to set some bit flags. For a logical OR the ">> 1"
> shift wouldn't make a difference. So it should be using a bitwise OR.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
I guess this is correct.
Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
prev parent reply other threads:[~2012-08-14 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 7:04 [patch] Staging: xgifb: fix bitwise vs logical bug Dan Carpenter
2012-08-14 10:45 ` Peter Hüwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208141245.21045.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).