kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: kernel-janitors@vger.kernel.org,
	Wayne Boyer <wayneb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org
Subject: drivers/scsi/ipr.c:8448:2-19: alloc with no test
Date: Sat, 18 Aug 2012 13:46:13 +0000	[thread overview]
Message-ID: <20120818134613.GA11000@localhost> (raw)

Hi Brian,

FYI, coccinelle warns about

  drivers/scsi/ipr.c:8448:2-19: alloc with no test, possible model on line 8457

vi +8448 drivers/scsi/ipr.c

  8443         if (ioa_cfg->sis64) {
  8444                 ioa_cfg->target_ids = kzalloc(sizeof(unsigned long) *
  8445                                               BITS_TO_LONGS(ioa_cfg->max_devs_supported), GFP_KERNEL);
  8446                 ioa_cfg->array_ids = kzalloc(sizeof(unsigned long) *
  8447                                              BITS_TO_LONGS(ioa_cfg->max_devs_supported), GFP_KERNEL);
> 8448                 ioa_cfg->vset_ids = kzalloc(sizeof(unsigned long) *
  8449                                             BITS_TO_LONGS(ioa_cfg->max_devs_supported), GFP_KERNEL);
  8450         }
  8451   

Thanks,
Fengguang

                 reply	other threads:[~2012-08-18 13:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120818134613.GA11000@localhost \
    --to=fengguang.wu@intel.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=wayneb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).