kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [samsung:devfreq-for-next 3/5] drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_leve
Date: Fri, 31 Aug 2012 06:54:02 +0000	[thread overview]
Message-ID: <20120831065402.GA6761@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

Hi Jonghwa,

FYI, there are new sparse warnings show up in

tree:   git://git.infradead.org/users/kmpark/linux-samsung devfreq-for-next
head:   90609cd121f47446e6a04862214423dbc75bd493
commit: 4b77f78761889635ba1abd2f4ec1e7f45012e48c [3/5] devfreq: Add sysfs node for representing frequency transition information.

All sparse warnings:

+ drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_level' was not declared. Should it be static?
+ drivers/devfreq/devfreq.c:86:5: sparse: symbol 'devfreq_update_status' was not declared. Should it be static?

vim +75 drivers/devfreq/devfreq.c
    72		return ERR_PTR(-ENODEV);
    73	}
    74	
  > 75	int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
    76	{
    77		int lev;
    78	

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

[-- Attachment #2: make-it-static-4b77f78.diff --]
[-- Type: text/x-diff, Size: 757 bytes --]

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 00e326c..e00a386 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -72,7 +72,7 @@ static struct devfreq *find_device_devfreq(struct device *dev)
 	return ERR_PTR(-ENODEV);
 }
 
-int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
+static int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
 {
 	int lev;
 
@@ -83,7 +83,7 @@ int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
 	return -EINVAL;
 }
 
-int devfreq_update_status(struct devfreq *devfreq, unsigned long freq)
+static int devfreq_update_status(struct devfreq *devfreq, unsigned long freq)
 {
 	int lev, prev_lev;
 	unsigned long cur_time;

             reply	other threads:[~2012-08-31  6:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31  6:54 Fengguang Wu [this message]
2012-08-31  6:57 ` [samsung:devfreq-for-next 3/5] drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_ jonghwa3.lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831065402.GA6761@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).