From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/1] mm: Fix unused function warnings in vmstat.c
Date: Tue, 04 Sep 2012 09:14:25 +0000 [thread overview]
Message-ID: <20120904091425.GA19396@mwanda> (raw)
In-Reply-To: <CAHve1mzC+x=z5L4-74EYhAmi7Jqc-XqD7u5yRctbHwgKVyO2dA@mail.gmail.com>
On Tue, Sep 04, 2012 at 10:43:27AM +0200, Luis G.F wrote:
> frag_start(), frag_next(), frag_stop(), walk_zones_in_node() throws
> compilation warnings (-Wunused-function) even when are currently used.
>
> This patchs fix the compilation warnings in vmstat.c
>
> Signed-off-by: Luis Gonzalez Fernandez <luisgf@gmail.com>
Don't send kernel janitor patches for stuff under mm/ or kernel/
etc. Best to start where there are fewer people involved. There
are a some problems with this patch, but don't fix and resend the
comments are just for educational purposes only.
The subject says "Fix" but really it's not a bug fix, it's just
silencing a warning. It doesn't change user visible behavior.
This should use the __unused define as in:
-static void *frag_start(struct seq_file *m, loff_t *pos)
+static void __unused *frag_start(struct seq_file *m, loff_t *pos)
The patch is corrupted. Read Documentation/email-clients.txt.
Send the patch to yourself and try apply it. Save the whole email
including headers and everything. `cat raw_email.txt | patch -p1`.
regards,
dan carpenter
prev parent reply other threads:[~2012-09-04 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 8:43 [PATCH 1/1] mm: Fix unused function warnings in vmstat.c Luis G.F
2012-09-04 9:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904091425.GA19396@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox