From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [staging-next] ozwpan: fix memcmp() test in oz_set_active_pd()
Date: Tue, 04 Sep 2012 17:33:15 +0000 [thread overview]
Message-ID: <20120904173315.GD19410@mwanda> (raw)
In-Reply-To: <1345393254-6060-1-git-send-email-tomas.winkler@intel.com>
On Tue, Sep 04, 2012 at 10:31:05AM -0700, Dan Carpenter wrote:
> On Sun, Aug 19, 2012 at 07:20:54PM +0300, Tomas Winkler wrote:
> > "addr" is a pointer so it's either 4 or 8 bytes, but actually we want
> > to compare 6 bytes (ETH_ALEN).
> >
> > As network stack already provides helper function
> > is_zero_ether_addr() we use that instead of memcmp
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Rupesh Gujare <rgujare@ozmodevices.com>
> > ---
>
> Generally I would frown on patch thievery but since the maintainer
> asked you to then it's fine.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops. Doesn't compile. I see you sent a v3 already.
regards,
dan carpenter
>
> regards,
> dan carpenter
prev parent reply other threads:[~2012-09-04 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 16:20 [staging-next] ozwpan: fix memcmp() test in oz_set_active_pd() Tomas Winkler
2012-09-04 17:31 ` Dan Carpenter
2012-09-04 17:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904173315.GD19410@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox