From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen
Date: Sun, 09 Sep 2012 19:13:01 +0000 [thread overview]
Message-ID: <20120909191301.GS19410@mwanda> (raw)
In-Reply-To: <20120909121939.GA19908@localhost>
On Sun, Sep 09, 2012 at 08:19:39PM +0800, Fengguang Wu wrote:
> Hi Matthew,
>
> FYI, there are new smatch warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
> head: 97ac9d1f363964dec7fbb20cf3c2e88336b4d801
> commit: 66f2adcdadea18a583d4f7cbd773847d635731a3 [73/77] EFI: Stash ROMs if they're not in the PCI BAR
>
> All smatch warnings:
>
> + arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing uninitialized 'pci_handle'.
These warnings probably have too high of a false positive rate to be
worth emailing about. Although this one looks like a real bug. We
should be passing "&pci_handle" to efi_call_phys5 instead of
"pci_handle".
I'm not sure why GCC doesn't warn about these. Anyway, it's because
GCC didn't warn about unitialized variables that I added it to
Smatch.
> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: add some parenthesis here?
> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: maybe use && instead of &
These are real but they duplicate Sparse warnings. :/
> arch/x86/boot/compressed/eboot.c:728 handle_ramdisks() error: potentially derefencing uninitialized 'fh'.
>
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-09 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 12:19 [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing Fengguang Wu
2012-09-09 19:13 ` Dan Carpenter [this message]
2012-09-13 17:04 ` [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120909191301.GS19410@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox