From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [integrity:next-ima-new-check-module-syscall 32/34] kernel/module.c:2450 copy_module_from_user() war
Date: Wed, 12 Sep 2012 02:16:47 +0000 [thread overview]
Message-ID: <20120912021647.GA17485@localhost> (raw)
Hi Kees,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-ima-new-check-module-syscall
head: 3167cf7685efd4855ed9e52e8b2470e8d2dcbf9c
commit: e0eb8f8fe012a54af6d00e0d1573cf1c824023d4 [32/34] module: add syscall to load module from fd
All smatch warnings:
arch/x86/include/asm/stacktrace.h:112 caller_frame_pointer() error: potentially derefencing uninitialized 'frame'.
arch/x86/include/asm/jump_label.h:25 arch_static_branch() info: ignoring unreachable code.
+ kernel/module.c:2450 copy_module_from_user() warn: maybe return -EFAULT instead of the bytes remaining?
vim +2450 kernel/module.c
2440 goto free_hdr;
2441
2442 err = check_info(info);
2443 if (err)
2444 goto free_hdr;
2445
2446 return err;
2447
2448 free_hdr:
2449 vfree(info->hdr);
> 2450 return err;
2451 }
2452
2453 /* Sets info->hdr and info->len. */
2454 int copy_module_from_fd(int fd, struct load_info *info)
2455 {
2456 struct file *file;
2457 int err;
2458 struct kstat stat;
2459 unsigned long size;
2460 off_t pos;
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
reply other threads:[~2012-09-12 2:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912021647.GA17485@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox