From: Tejun Heo <tj@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xattr: mark variable as uninitialized to make both gcc and smatch happy
Date: Wed, 12 Sep 2012 18:42:00 +0000 [thread overview]
Message-ID: <20120912184200.GQ7677@google.com> (raw)
In-Reply-To: <20120912143112.GE19694@redhat.com>
On Wed, Sep 12, 2012 at 10:31:13AM -0400, Aristeu Rozanski wrote:
> new_xattr in __simple_xattr_set() is only initialized with a valid
> pointer if value is not NULL, which only happens if this function is
> called directly with the intention to remove an existing extended
> attribute. Even being safe to be this way, smatch warns about possible
> NULL dereference. Dan Carpenter suggested using uninitialized_var()
> which will make both gcc and smatch happy.
>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
applied to cgroup/for-3.7. Thanks.
--
tejun
prev parent reply other threads:[~2012-09-12 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 14:31 [PATCH] xattr: mark variable as uninitialized to make both gcc and smatch happy Aristeu Rozanski
2012-09-12 18:42 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912184200.GQ7677@google.com \
--to=tj@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox