From: Daniel Cotey <puff65537@bansheeslibrary.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: silicom: remove S_IWOTH from proc declaration
Date: Wed, 12 Sep 2012 18:31:14 +0000 [thread overview]
Message-ID: <20120913023411.GA1529@elbert.example.com> (raw)
In-Reply-To: <20120912075733.GA26524@elgon.mountain>
On Wed, Sep 12, 2012 at 10:57:33AM +0300, Dan Carpenter wrote:
> We don't need these to be world writable or group writable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is linux-next stuff. The code in bp_proc.c is ifdefed out, and I
> wasn't able to compile it.
>
> diff --git a/drivers/staging/silicom/bp_proc.c b/drivers/staging/silicom/bp_proc.c
> index 4fe862d..6ad4b27 100644
> --- a/drivers/staging/silicom/bp_proc.c
> +++ b/drivers/staging/silicom/bp_proc.c
> @@ -106,8 +106,7 @@ bypass_proc_create_entry_sd(struct pfs_unit *pfs_unit_curr,
> pfs_unit_curr->proc_entry = create_proc_entry(pfs_unit_curr->proc_name,
> S_IFREG | S_IRUSR |
> S_IWUSR | S_IRGRP |
> - S_IWGRP | S_IROTH |
> - S_IWOTH, parent_pfs);
> + S_IROTH, parent_pfs);
> if (pfs_unit_curr->proc_entry = 0) {
>
> return -1;
> diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c
> index 0d96196..6e999c7 100644
> --- a/drivers/staging/silicom/bp_mod.c
> +++ b/drivers/staging/silicom/bp_mod.c
> @@ -7724,8 +7724,7 @@ bypass_proc_create_entry_sd(struct pfs_unit_sd *pfs_unit_curr,
> pfs_unit_curr->proc_entry = create_proc_entry(pfs_unit_curr->proc_name,
> S_IFREG | S_IRUSR |
> S_IWUSR | S_IRGRP |
> - S_IWGRP | S_IROTH |
> - S_IWOTH, parent_pfs);
> + S_IROTH, parent_pfs);
> if (pfs_unit_curr->proc_entry = 0) {
>
> return -1;
I need to check my test setup tonight, but I do think apps need group write.
Regards,
Daniel Cotey
prev parent reply other threads:[~2012-09-12 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 7:57 [patch] Staging: silicom: remove S_IWOTH from proc declaration Dan Carpenter
2012-09-12 18:31 ` Daniel Cotey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913023411.GA1529@elbert.example.com \
--to=puff65537@bansheeslibrary.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox