public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: [sound-unstable:master 118/143] sound/pci/hda/patch_cirrus.c:1414:10: sparse: Initializer entry defi
Date: Thu, 13 Sep 2012 07:49:40 +0000	[thread overview]
Message-ID: <20120913074940.GA25767@localhost> (raw)

Hi Takashi,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git master
head:   82cb521360dfd32f4f03ceaa74ef6b83ae983593
commit: ef596a57b4d7d8b258beb570ed309ef85bf24dd1 [118/143] ALSA: hda - Add support for MacBook Pro 10,1

All sparse warnings:

+ sound/pci/hda/patch_cirrus.c:1414:10: sparse: Initializer entry defined twice
  sound/pci/hda/patch_cirrus.c:1418:10:   also defined here

The root cause is, CS420X_MBP101 = CS420X_GPIO_23:

        @@ -85,6 +85,8 @@ enum {
=>              CS420X_GPIO_23,
                CS420X_IMAC27_122 = CS420X_GPIO_23,
                CS420X_APPLE = CS420X_GPIO_13,
=>      +       CS420X_MBP101,
        +       CS420X_MBP101_COEF,
                CS420X_AUTO,
         };
         
vim +1414 sound/pci/hda/patch_cirrus.c
  1404		[CS420X_IMAC27] = {
  1405			.type = HDA_FIXUP_PINS,
  1406			.v.pins = imac27_pincfgs,
  1407			.chained = true,
  1408			.chain_id = CS420X_GPIO_13,
  1409		},
  1410		[CS420X_GPIO_13] = {
  1411			.type = HDA_FIXUP_FUNC,
  1412			.v.func = cs420x_fixup_gpio_13,
  1413		},
> 1414		[CS420X_GPIO_23] = {
  1415			.type = HDA_FIXUP_FUNC,
  1416			.v.func = cs420x_fixup_gpio_23,
  1417		},
  1418		[CS420X_MBP101] = {
  1419			.type = HDA_FIXUP_PINS,
  1420			.v.pins = mbp101_pincfgs,
  1421			.chained = true,
  1422			.chain_id = CS420X_MBP101_COEF,
  1423		},
  1424		[CS420X_MBP101_COEF] = {

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

             reply	other threads:[~2012-09-13  7:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  7:49 Fengguang Wu [this message]
2012-09-13  8:01 ` [sound-unstable:master 118/143] sound/pci/hda/patch_cirrus.c:1414:10: sparse: Initializer entry Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913074940.GA25767@localhost \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox