From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
Hansjoerg Lipp <hjlipp@web.de>,
kernel-janitors@vger.kernel.org, Tilman Schmidt <tilman@imap.cc>,
Karsten Keil <isdn@linux-pingi.de>,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree
Date: Thu, 13 Sep 2012 09:19:59 +0000 [thread overview]
Message-ID: <20120913091959.GK19396@mwanda> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6FEE@saturn3.aculab.com>
On Thu, Sep 13, 2012 at 09:31:45AM +0100, David Laight wrote:
> > Remove useless kfree() and clean up code related to the removal.
> ...
> > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
> > index aa41485..30a6b17 100644
> > --- a/drivers/isdn/gigaset/common.c
> > +++ b/drivers/isdn/gigaset/common.c
> > @@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors,
> > return drv;
> >
> > error:
> > - kfree(drv->cs);
> > kfree(drv);
> > return NULL;
> > }
> >
>
> Seems to me that (assuming kfree(NULL) is ok) the kfree()
> is best left in - just in case some other error path is
> added after drv->cs is assigned.
> Better safe than a memory leak.
No. Delete vestigial code. There are all kinds of no-ops we could
add to the unwind bits of code if we wanted to so why is "drv->cs"
better than anything else.
First of all, no one is going to change the ISDN code to add an
allocation, but if they did then they have to make sure they don't
leak memory. That's how it always works. They can't just assume
that there is going to be a forgotten kfree() hanging off to the
side which is going to take care of it.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-13 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 15:06 [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree Peter Senna Tschudin
2012-09-13 8:31 ` David Laight
2012-09-13 9:19 ` Dan Carpenter [this message]
2012-09-13 9:27 ` Peter Senna Tschudin
2012-09-13 9:52 ` Tilman Schmidt
2012-09-13 21:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913091959.GK19396@mwanda \
--to=dan.carpenter@oracle.com \
--cc=David.Laight@ACULAB.COM \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox