Re: ext4: convert file system to meta_bg if needed during resizing

Theodore Ts'o
2012-09-19T03:51:32Z

On Tue, Sep 18, 2012 at 02:46:35PM +0300, Dan Carpenter wrote:
> 1775 struct ext4_inode_info *ei = 0;
> ^^^^^^
> Sparse is going to complain. Not sure why Fengguang hasn't emailed you.

> 1791 ei = EXT4_I(inode);
> ^^^^^^^^^^^^^^^^^^
> We only set "ei" if EXT4_FEATURE_COMPAT_RESIZE_INODE.
> ...

> 1829 nr = le32_to_cpu(ei->i_data[EXT4_DIND_BLOCK]);
> ^^^^^^^^^^
> Null deref. Perhaps inode implies EXT4_FEATURE_COMPAT_RESIZE_INODE?

Inode does imply EXT4_FEATURE_COMPAT_RESIZE_INODE, but I should make
the code cleaner.

Thanks for pointing this out.

- Ted