Re: ext4: convert file system to meta_bg if needed during resizing

Fengguang Wu
2012-09-18T11:52:22Z

On Tue, Sep 18, 2012 at 02:46:35PM +0300, Dan Carpenter wrote:
> Hello Theodore Ts'o,
>
> The patch 1c6bd7173d66: "ext4: convert file system to meta_bg if
> needed during resizing" from Sep 13, 2012, leads to the following
> warning:
> fs/ext4/resize.c:1829 ext4_convert_meta_bg()
> error: potential NULL dereference 'ei'.
>
> 1770 static int ext4_convert_meta_bg(struct super_block *sb, struct inode *inode)
> 1771 {
> 1772 handle_t *handle;
> 1773 struct ext4_sb_info *sbi = EXT4_SB(sb);
> 1774 struct ext4_super_block *es = sbi->s_es;
> 1775 struct ext4_inode_info *ei = 0;
> ^^^^^^
> Sparse is going to complain. Not sure why Fengguang hasn't emailed you.

Sorry I'm doing lots of changes these days and they apparently break
many things.. I'd expect the build test system to gradually restore to
normal in the coming days.

Thanks,
Fengguang