From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [userns:userns-always-map-user-v58 86/150] fs/ncpfs/inode.c:335 ncp_show_options() warn: if();
Date: Fri, 21 Sep 2012 08:44:58 +0000 [thread overview]
Message-ID: <20120921084458.GF4587@mwanda> (raw)
In-Reply-To: <20120921082232.GA5132@localhost>
On Fri, Sep 21, 2012 at 04:40:05PM +0800, Fengguang Wu wrote:
> On Fri, Sep 21, 2012 at 01:31:25AM -0700, Eric W. Biederman wrote:
> > Fengguang Wu <fengguang.wu@intel.com> writes:
> >
> > > Hi Eric,
> > >
> > > FYI, there are new smatch warnings show up in
> > >
> > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git userns-always-map-user-v58
> > > head: cf7198a6b74906aa363a8507d6f9cbdf56e42dc1
> > > commit: 84ec77ea8a96e568f20bec4465c1fbde2c066cf8 [86/150] userns: Convert ncpfs to use kuid and kgid where appropriate
> > >
> > > All smatch warnings:
> > >
> > > + fs/ncpfs/inode.c:335 ncp_show_options() warn: if();
> > > fs/ncpfs/inode.c:654 ncp_fill_super() Error invalid range 4096 to -1
> >
> > Good catch. Thanks.
> >
> > Did you just start running smatch tests? I haven't looked at ncpfs for
> > a long time.
>
> Yes. :) I don't quite get the old "invalid range 4096 to -1" warning,
> perhaps it's fine to just ignore it.
>
Yes, yes. This shouldn't be there in the latest Smatch. (I thought
you were on that thread). Let me know if it's still an issue.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-21 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 8:22 [userns:userns-always-map-user-v58 86/150] fs/ncpfs/inode.c:335 ncp_show_options() warn: if(); Fengguang Wu
2012-09-21 8:31 ` Eric W. Biederman
2012-09-21 8:40 ` Fengguang Wu
2012-09-21 8:44 ` Dan Carpenter [this message]
2012-09-21 8:51 ` Dan Carpenter
2012-09-21 8:53 ` Fengguang Wu
2012-09-21 8:55 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921084458.GF4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox