[next:akpm 202/376] arch/sh/kernel/ioport.c:14:15: error: conflicting type qualifiers for 'sh_io_por

[next:akpm 202/376] arch/sh/kernel/ioport.c:14:15: error: conflicting type qualifiers for 'sh_io_por

[Fengguang Wu]

Hi Andi,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
head:   69921c36f9e0e4e7952fa2583bf2d33713835eaf
commit: 11f7c1c694b94586a232a50eebdd623255d60d72 [202/376] sections: fix section conflicts in arch/sh
config: sh-titan_defconfig

All related error/warning messages:

arch/sh/kernel/ioport.c:14:15: error: conflicting type qualifiers for 'sh_io_port_base'
In file included from include/linux/io.h:22:0,
                 from arch/sh/kernel/ioport.c:12:
arch/sh/include/asm/io.h:137:28: note: previous declaration of 'sh_io_port_base' was here
arch/sh/kernel/ioport.c:15:1: error: conflicting type qualifiers for 'sh_io_port_base'
In file included from include/linux/io.h:22:0,
                 from arch/sh/kernel/ioport.c:12:
arch/sh/include/asm/io.h:137:28: note: previous declaration of 'sh_io_port_base' was here

vim +14 arch/sh/kernel/ioport.c
     8	 * License.  See the file "COPYING" in the main directory of this archive
     9	 * for more details.
    10	 */
    11	#include <linux/module.h>
    12	#include <linux/io.h>
    13	
  > 14	unsigned long sh_io_port_base __read_mostly = -1;
    15	EXPORT_SYMBOL(sh_io_port_base);
    16	
    17	void __iomem *__ioport_map(unsigned long addr, unsigned int size)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Re: [next:akpm 202/376] arch/sh/kernel/ioport.c:14:15: error: conflicting type qualifiers for 'sh_io

[Andi Kleen]

On Fri, Sep 21, 2012 at 06:56:35PM +0800, Fengguang Wu wrote:
> Hi Andi,
> 
> FYI, kernel build failed on
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> head:   69921c36f9e0e4e7952fa2583bf2d33713835eaf
> commit: 11f7c1c694b94586a232a50eebdd623255d60d72 [202/376] sections: fix section conflicts in arch/sh
> config: sh-titan_defconfig

Does this patch work?

diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
index 0cf60a6..73a23f4 100644
--- a/arch/sh/include/asm/io.h
+++ b/arch/sh/include/asm/io.h
@@ -134,7 +134,7 @@ __BUILD_MEMORY_STRING(__raw_, q, u64)
  * load/store instructions. sh_io_port_base is the virtual address to
  * which all ports are being mapped.
  */
-extern const unsigned long sh_io_port_base;
+extern unsigned long sh_io_port_base;
 
 static inline void __set_io_port_base(unsigned long pbase)
 {

Re: [next:akpm 202/376] arch/sh/kernel/ioport.c:14:15: error: conflicting type qualifiers for 'sh_io

[Andrew Morton]

On Fri, 21 Sep 2012 07:51:53 -0700
Andi Kleen <ak@linux.intel.com> wrote:

> On Fri, Sep 21, 2012 at 06:56:35PM +0800, Fengguang Wu wrote:
> > Hi Andi,
> > 
> > FYI, kernel build failed on
> > 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> > head:   69921c36f9e0e4e7952fa2583bf2d33713835eaf
> > commit: 11f7c1c694b94586a232a50eebdd623255d60d72 [202/376] sections: fix section conflicts in arch/sh
> > config: sh-titan_defconfig
> 
> Does this patch work?
> 
> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
> index 0cf60a6..73a23f4 100644
> --- a/arch/sh/include/asm/io.h
> +++ b/arch/sh/include/asm/io.h
> @@ -134,7 +134,7 @@ __BUILD_MEMORY_STRING(__raw_, q, u64)
>   * load/store instructions. sh_io_port_base is the virtual address to
>   * which all ports are being mapped.
>   */
> -extern const unsigned long sh_io_port_base;
> +extern unsigned long sh_io_port_base;
>  
>  static inline void __set_io_port_base(unsigned long pbase)
>  {

yup.