public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [signal:master 94/94] kernel/signal.c:3119:35: error: expected identifier before '(' token
Date: Fri, 21 Sep 2012 12:38:19 +0000	[thread overview]
Message-ID: <20120921123819.GJ13973@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120921071926.GA1253@localhost>

On Fri, Sep 21, 2012 at 03:19:26PM +0800, Fengguang Wu wrote:
> Hi Al,
> 
> FYI, kernel build failed on
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal.git master
> head:   1320d2cc9be60744e2e0bbb73f8e2653a77bf59c
> commit: 1320d2cc9be60744e2e0bbb73f8e2653a77bf59c [94/94] mips: sigaltstack conversion
> config: mips-allnoconfig
> 
> All related error/warning messages:
> 
> kernel/signal.c: In function 'sys_sigaltstack':
> kernel/signal.c:3119:35: error: expected identifier before '(' token
> kernel/signal.c:3120:1: warning: control reaches end of non-void function [-Wreturn-type]

D'oh...  broken user_stack_pointer() definition -
#define foo(regs) ((regs)->regs[something])
is a bad idea...  Fixed.

      reply	other threads:[~2012-09-21 12:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21  7:19 [signal:master 94/94] kernel/signal.c:3119:35: error: expected identifier before '(' token Fengguang Wu
2012-09-21 12:38 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120921123819.GJ13973@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox