public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [md:for-next 29/29] ERROR: "__tracepoint_block_unplug" [drivers/md/raid456.ko] undefined!
Date: Mon, 24 Sep 2012 23:34:53 +0000	[thread overview]
Message-ID: <20120925093453.0fbb2acc@notabene.brown> (raw)
In-Reply-To: <20120924081513.GA12612@localhost>

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Mon, 24 Sep 2012 16:15:13 +0800 Fengguang Wu <fengguang.wu@intel.com>
wrote:

> Hi NeilBrown,
> 
> FYI, kernel build failed on
> 
> tree:   git://neil.brown.name/md for-next/14817e9
> head:   14817e9a6dab027db44783d28429d14f601547a2
> commit: 14817e9a6dab027db44783d28429d14f601547a2 [29/29] md/raid5: add blktrace calls
> config: sparc64-defconfig
> 
> ERROR: "__tracepoint_block_unplug" [drivers/md/raid456.ko] undefined!
> 
> The root cause is, the block trace points are only available when
> block/blk-core.c is compiled in.

Hi,
 thanks for this.
blk-core must be compiled in, else raid456 wouldn't get compiled
CONFIG_MD_RAID456 eventually depends on CONFIG_BLOCK.

The problem is simply that tracepoint_block_unplug hasn't been exported.
This fixes it:

diff --git a/block/blk-core.c b/block/blk-core.c
index 4b4dbdf..ef55ae0 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -40,6 +40,7 @@
 EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_remap);
 EXPORT_TRACEPOINT_SYMBOL_GPL(block_rq_remap);
 EXPORT_TRACEPOINT_SYMBOL_GPL(block_bio_complete);
+EXPORT_TRACEPOINT_SYMBOL_GPL(block_unplug);
 
 DEFINE_IDA(blk_queue_ida);
 

I'll see if Jens will take it.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2012-09-24 23:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  8:15 [md:for-next 29/29] ERROR: "__tracepoint_block_unplug" [drivers/md/raid456.ko] undefined! Fengguang Wu
2012-09-24 23:34 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925093453.0fbb2acc@notabene.brown \
    --to=neilb@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox