[slave-dma:topic/dmaengine_dt 17/20] drivers/dma/dmaengine.c:65:26: fatal error: linux/of_dma.h: No

[slave-dma:topic/dmaengine_dt 17/20] drivers/dma/dmaengine.c:65:26: fatal error: linux/of_dma.h: No

[Fengguang Wu]

Hi Vinod,

I noticed that kernel build failed on this commit and get fixed by
the next next commit. Do you want me to do commit-by-commit tests on
your tree, or test branch head first which will ignore such interim errors?

Thanks,
Fengguang
---

tree:   git://git.infradead.org/users/vkoul/slave-dma.git topic/dmaengine_dt
head:   be2e7726dc84371736996e05d10331f70afd50c1
commit: 528499a7037ebec0636d928f88cd783c618df3c5 [17/20] dmaengine: add helper function to request a slave DMA channel
config: x86_64-allmodconfig


All error/warnings:

drivers/dma/dmaengine.c:65:26: fatal error: linux/of_dma.h: No such file or directory
compilation terminated.

vim +65 drivers/dma/dmaengine.c
    59	#include <linux/rcupdate.h>
    60	#include <linux/mutex.h>
    61	#include <linux/jiffies.h>
    62	#include <linux/rculist.h>
    63	#include <linux/idr.h>
    64	#include <linux/slab.h>
  > 65	#include <linux/of_dma.h>
    66	
    67	static DEFINE_MUTEX(dma_list_mutex);
    68	static DEFINE_IDR(dma_idr);

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Re: [slave-dma:topic/dmaengine_dt 17/20] drivers/dma/dmaengine.c:65:26: fatal error: linux/of_dma.h:

[Vinod Koul]

On Tue, 2012-09-25 at 19:37 +0800, Fengguang Wu wrote:
> Hi Vinod,
> 
> I noticed that kernel build failed on this commit and get fixed by
> the next next commit. Do you want me to do commit-by-commit tests on
> your tree, or test branch head first which will ignore such interim errors?
test branch head should be fine. 

But yes for kernel each patch needs to build on its own, this should not
have happened in the first place.


> Thanks,
> Fengguang
> ---
> 
> tree:   git://git.infradead.org/users/vkoul/slave-dma.git topic/dmaengine_dt
> head:   be2e7726dc84371736996e05d10331f70afd50c1
> commit: 528499a7037ebec0636d928f88cd783c618df3c5 [17/20] dmaengine: add helper function to request a slave DMA channel
> config: x86_64-allmodconfig
> 
> 
> All error/warnings:
> 
> drivers/dma/dmaengine.c:65:26: fatal error: linux/of_dma.h: No such file or directory
> compilation terminated.
> 
> vim +65 drivers/dma/dmaengine.c
>     59	#include <linux/rcupdate.h>
>     60	#include <linux/mutex.h>
>     61	#include <linux/jiffies.h>
>     62	#include <linux/rculist.h>
>     63	#include <linux/idr.h>
>     64	#include <linux/slab.h>
>   > 65	#include <linux/of_dma.h>
>     66	
>     67	static DEFINE_MUTEX(dma_list_mutex);
>     68	static DEFINE_IDR(dma_idr);
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Centre
> Fengguang Wu, Yuanhan Liu                              Intel Corporation


-- 
~Vinod

Re: [slave-dma:topic/dmaengine_dt 17/20] drivers/dma/dmaengine.c:65:26: fatal error: linux/of_dma.h:

[Fengguang Wu]

On Tue, Sep 25, 2012 at 09:55:13PM +0530, Vinod Koul wrote:
> On Tue, 2012-09-25 at 19:37 +0800, Fengguang Wu wrote:
> > Hi Vinod,
> > 
> > I noticed that kernel build failed on this commit and get fixed by
> > the next next commit. Do you want me to do commit-by-commit tests on
> > your tree, or test branch head first which will ignore such interim errors?
> test branch head should be fine. 

OK!

> But yes for kernel each patch needs to build on its own, this should not
> have happened in the first place.

Yeah, for that purpose ktest or aiaiai are good tools that's designed
to run such checks before pushing new commits. :-)

Thanks,
Fengguang