[samsung:v4l-next 51/121] drivers/media/usb/tlg2300/pd-alsa.c:309:3: error: implicit declaration of

[samsung:v4l-next 51/121] drivers/media/usb/tlg2300/pd-alsa.c:309:3: error: implicit declaration of

[Fengguang Wu]

Hi Alan,

FYI, kernel build failed on

tree:   git://git.infradead.org/users/kmpark/linux-samsung v4l-next
head:   01882ac3debd75dcf39c45b9cfc9eb12c4b50ba0
commit: da35de640a0e9c805aba70439f524234890b96c5 [51/121] [media] tlg2300: fix missing check for audio creation
config: x86_64-allmodconfig

All error/warnings:

drivers/media/usb/tlg2300/pd-alsa.c: In function 'poseidon_audio_init':
drivers/media/usb/tlg2300/pd-alsa.c:309:3: error: implicit declaration of function 'snd_free_card' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

vim +309 drivers/media/usb/tlg2300/pd-alsa.c
   303		ret = snd_card_create(-1, "Telegent", THIS_MODULE, 0, &card);
   304		if (ret != 0)
   305			return ret;
   306	
   307		ret = snd_pcm_new(card, "poseidon audio", 0, 0, 1, &pcm);
   308		if (ret < 0) {
 > 309			snd_free_card(card);
   310			return ret;
   311		}
   312		snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &pcm_capture_ops);

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Re: [samsung:v4l-next 51/121] drivers/media/usb/tlg2300/pd-alsa.c:309:3: error: implicit declaration

[Alan Cox]

> vim +309 drivers/media/usb/tlg2300/pd-alsa.c
>    303		ret = snd_card_create(-1, "Telegent",
> THIS_MODULE, 0, &card); 304		if (ret != 0)
>    305			return ret;
>    306	
>    307		ret = snd_pcm_new(card, "poseidon audio", 0, 0,
> 1, &pcm); 308		if (ret < 0) {
>  > 309			snd_free_card(card);

Umm I sent the version out then - should be snd_card_free(card) I
think !

Re: [samsung:v4l-next 51/121] drivers/media/usb/tlg2300/pd-alsa.c:309:3: error: implicit declaration

[Mauro Carvalho Chehab]

Em Wed, 26 Sep 2012 17:50:35 +0100
Alan Cox <alan@linux.intel.com> escreveu:

> > vim +309 drivers/media/usb/tlg2300/pd-alsa.c
> >    303		ret = snd_card_create(-1, "Telegent",
> > THIS_MODULE, 0, &card); 304		if (ret != 0)
> >    305			return ret;
> >    306	
> >    307		ret = snd_pcm_new(card, "poseidon audio", 0, 0,
> > 1, &pcm); 308		if (ret < 0) {
> >  > 309			snd_free_card(card);
> 
> Umm I sent the version out then - should be snd_card_free(card) I
> think !

Yeah, I had to apply this patch on my tree, in order to fix compilation:

commit fac44ee564a54db020ad384e0de94b5d8be3c6b5
Author: Mauro Carvalho Chehab <mchehab@redhat.com>
Date:   Sun Sep 23 16:42:44 2012 -0300

    [media] pd-alsa: fix compilation breakage by commit da35de640
    
    commit da35de640 broke compilation, as it reverted the name of the
    usb card free function.
    
    Cc: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/usb/tlg2300/pd-alsa.c b/drivers/media/usb/tlg2300/pd-alsa.c
index 0c77869..3f3e141 100644
--- a/drivers/media/usb/tlg2300/pd-alsa.c
+++ b/drivers/media/usb/tlg2300/pd-alsa.c
@@ -306,7 +306,7 @@ int poseidon_audio_init(struct poseidon *p)
 
 	ret = snd_pcm_new(card, "poseidon audio", 0, 0, 1, &pcm);
 	if (ret < 0) {
-		snd_free_card(card);
+		snd_card_free(card);
 		return ret;
 	}
 	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &pcm_capture_ops);

Regards,
Mauro