From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH usb:usb-next] USB: ezusb: make some vars/funcs static
Date: Thu, 27 Sep 2012 17:10:26 +0000 [thread overview]
Message-ID: <20120927171026.GA25153@kroah.com> (raw)
In-Reply-To: <20120927062413.GA28643@localhost>
On Thu, Sep 27, 2012 at 02:24:13PM +0800, Fengguang Wu wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> drivers/usb/misc/ezusb.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
> head: 70c048a238c780c226eb4b115ebaa908cb3b34ec
> commit: 70c048a238c780c226eb4b115ebaa908cb3b34ec [72/73] USB: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
>
> + drivers/usb/misc/ezusb.c:25:22: sparse: symbol 'ezusb_fx1' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:30:22: sparse: symbol 'ezusb_fx2' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:39:5: sparse: symbol 'ezusb_writememory' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:63:5: sparse: symbol 'ezusb_set_reset' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:73:5: sparse: symbol 'ezusb_fx1_set_reset' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:79:5: sparse: symbol 'ezusb_fx2_set_reset' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:147:5: sparse: symbol 'ezusb_fx1_ihex_firmware_download' was not declared. Should it be static?
> + drivers/usb/misc/ezusb.c:154:5: sparse: symbol 'ezusb_fx2_ihex_firmware_download' was not declared. Should it be static?
Put all of this information (well the sparse warnings) up above in the
changelog area of the patch, it's good to have.
> @@ -36,7 +36,7 @@ struct ezusb_fx_type ezusb_fx2 = {
> #define WRITE_INT_RAM 0xA0
> #define WRITE_EXT_RAM 0xA3
>
> -int ezusb_writememory(struct usb_device *dev, int address,
> +static int ezusb_writememory(struct usb_device *dev, int address,
> unsigned char *data, int length, __u8 request)
> {
> int result;
> @@ -60,7 +60,7 @@ int ezusb_writememory(struct usb_device
> }
> EXPORT_SYMBOL_GPL(ezusb_writememory);
You just marked a symbol that is exported as static? What is going on
here? This can't be correct, is there a .h file somewhere that we need
to add these exported symbols to which would fix up sparse, right?
Rene, why have functions exported that no one uses outside of the
module?
As it is, I can't take this patch, sorry.
greg k-h
next prev parent reply other threads:[~2012-09-27 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 6:24 [PATCH usb:usb-next] USB: ezusb: make some vars/funcs static Fengguang Wu
2012-09-27 17:10 ` Greg Kroah-Hartman [this message]
2012-09-28 9:39 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927171026.GA25153@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox