From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [nouveau:master 82/96] drivers/gpu/drm/nouveau/core/subdev/bios/therm.c:59:1: sparse: symbol
Date: Thu, 27 Sep 2012 17:52:35 +0000 [thread overview]
Message-ID: <20120927175235.GC5517@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]
Hi Martin,
FYI, there are new sparse warnings show up in
tree: git://git.freedesktop.org/git/nouveau/linux-2.6 master
head: 301e77f5b7968ff10eac8f3938c30963d8fc0ac3
commit: 1efe51f9b6c36f21c18b83219e70ab7bb822d3ff [82/96] drm/nouveau/therm: rework thermal table parsing
+ drivers/gpu/drm/nouveau/core/subdev/bios/therm.c:59:1: sparse: symbol 'nvbios_therm_entry' was not declared. Should it be static?
vim +59 drivers/gpu/drm/nouveau/core/subdev/bios/therm.c
1efe51f9 (Martin Peres 2012-08-16 58) u16
1efe51f9 (Martin Peres 2012-08-16 @59) nvbios_therm_entry(struct nouveau_bios *bios, int idx, u8 *ver, u8 *len)
1efe51f9 (Martin Peres 2012-08-16 60) {
1efe51f9 (Martin Peres 2012-08-16 61) u8 hdr, cnt;
1efe51f9 (Martin Peres 2012-08-16 62) u16 therm = therm_table(bios, ver, &hdr, len, &cnt);
1efe51f9 (Martin Peres 2012-08-16 63) if (therm && idx < cnt)
1efe51f9 (Martin Peres 2012-08-16 64) return therm + idx * *len;
1efe51f9 (Martin Peres 2012-08-16 65) return 0x0000;
1efe51f9 (Martin Peres 2012-08-16 66) }
1efe51f9 (Martin Peres 2012-08-16 67)
Please consider folding the attached diff :-)
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
[-- Attachment #2: make-it-static-1efe51f.diff --]
[-- Type: text/x-diff, Size: 503 bytes --]
diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/therm.c b/drivers/gpu/drm/nouveau/core/subdev/bios/therm.c
index 862a08a..338ba50 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bios/therm.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bios/therm.c
@@ -55,7 +55,7 @@ therm_table(struct nouveau_bios *bios, u8 *ver, u8 *hdr, u8 *len, u8 *cnt)
return therm + nv_ro08(bios, therm + 1);
}
-u16
+static u16
nvbios_therm_entry(struct nouveau_bios *bios, int idx, u8 *ver, u8 *len)
{
u8 hdr, cnt;
reply other threads:[~2012-09-27 17:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927175235.GC5517@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox