From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [nouveau:master 86/96] drivers/gpu/drm/nouveau/core/subdev/therm/fan.c:134:29: sparse: constant
Date: Thu, 27 Sep 2012 17:53:18 +0000 [thread overview]
Message-ID: <20120927175318.GE5517@localhost> (raw)
In-Reply-To: <20120927061057.GB26998@localhost>
Hi Martin,
FYI, there are new sparse warnings show up in
tree: git://git.freedesktop.org/git/nouveau/linux-2.6 master
head: 301e77f5b7968ff10eac8f3938c30963d8fc0ac3
commit: 7303dcd8a45f9616c3d1e6f46f5f14639a6696f1 [86/96] drm/nouveau/fan: rewrite the fan tachometer driver to get more precision, faster
+ drivers/gpu/drm/nouveau/core/subdev/therm/fan.c:134:29: sparse: constant 60000000000 is so big it is long long
? drivers/gpu/drm/nouveau/core/subdev/therm/nv40.c:163:2: sparse: no newline at end of file
? drivers/gpu/drm/nouveau/core/subdev/therm/nv40.c:79:1: sparse: symbol 'nv40_fan_pwm_get' was not declared. Should it be static?
? drivers/gpu/drm/nouveau/core/subdev/therm/nv40.c:105:1: sparse: symbol 'nv40_fan_pwm_set' was not declared. Should it be static?
? drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c:54:1: sparse: symbol 'nv50_fan_pwm_get' was not declared. Should it be static?
? drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c:70:1: sparse: symbol 'nv50_fan_pwm_set' was not declared. Should it be static?
? drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c:83:1: sparse: symbol 'nv50_temp_get' was not declared. Should it be static?
vim +134 drivers/gpu/drm/nouveau/core/subdev/therm/fan.c
7303dcd8 (Martin Peres 2012-09-02 133) if (cycles = 5) {
7303dcd8 (Martin Peres 2012-09-02 @134) tach = (u64)60000000000;
7303dcd8 (Martin Peres 2012-09-02 135) do_div(tach, (end - start));
7303dcd8 (Martin Peres 2012-09-02 136) return tach;
7303dcd8 (Martin Peres 2012-09-02 137) } else
7303dcd8 (Martin Peres 2012-09-02 138) return 0;
c4f52f28 (Martin Peres 2012-09-02 139) }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
prev parent reply other threads:[~2012-09-27 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 6:10 [nouveau:master 86/96] drivers/gpu/drm/nouveau/core/subdev/therm/base.c:38:2: warning: enumeration Fengguang Wu
2012-09-27 17:53 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927175318.GE5517@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox