From mboxrd@z Thu Jan  1 00:00:00 1970
From: Theodore Ts'o <tytso@mit.edu>
Date: Mon, 01 Oct 2012 03:02:39 +0000
Subject: Re: [ext4:dev 47/50] fs/ext4/extents.c:4949 ext4_ext_punch_hole() warn: inconsistent returns mutex:&
Message-Id: <20121001030239.GA23264@thunk.org>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20121001025047.GB12711@localhost>
In-Reply-To: <20121001025047.GB12711@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, kernel-janitors@vger.kernel.org, linux-ext4@vger.kernel.org

On Mon, Oct 01, 2012 at 10:50:47AM +0800, Fengguang Wu wrote:
> Hi Dmitry,
> 
> FYI, there are new smatch warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> head:   07043757c1a4018a04aded14deb1f28269a4b2ad
> commit: c6a59106b4106d13dc824a388c5572ddd65a0779 [47/50] ext4: punch_hole should wait for DIO writers
> 
>   arch/x86/include/asm/jump_label.h:25 arch_static_branch() info: ignoring unreachable code.
> + fs/ext4/extents.c:4949 ext4_ext_punch_hole() warn: inconsistent returns mutex:&inode->i_mutex: locked (4813,4815) unlocked (4806,4949)

Hi Fengguang,

	Thanks for pointing this out!  I've fixed the obvious bug in
the commit once the smatch warning was pointed out.

					- Ted