From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesper Nilsson <jesper.nilsson@axis.com>
Date: Wed, 03 Oct 2012 10:46:52 +0000
Subject: Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
Message-Id: <20121003104652.GK1390@axis.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20120928130608.GA5158@localhost>
In-Reply-To: <20120928130608.GA5158@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>

On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote:
> Hi Jesper,

Hi!

> FYI, a rather old build bug that's introduced by
> 
> bafef0a cris build fixes: update eth_v10.c ethernet driver
> 
> All error/warnings:
> 
> drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
> drivers/net/cris/eth_v10.c:1131:1: note: declared here

Yep, I can't figure out why the followup patches never reached mainline,
but we have fixes for exactly that in our in-house tree.
I'll push some move patches after this merge window.

> vim +1715 drivers/net/cris/eth_v10.c
> 
> ^1da177e (Linus Torvalds 2005-04-16  1710) 
> bafef0ae (Jesper Nilsson 2007-11-14  1711) #ifdef CONFIG_NET_POLL_CONTROLLER
> bafef0ae (Jesper Nilsson 2007-11-14  1712) static void
> bafef0ae (Jesper Nilsson 2007-11-14  1713) e100_netpoll(struct net_device* netdev)
> bafef0ae (Jesper Nilsson 2007-11-14  1714) {
> bafef0ae (Jesper Nilsson 2007-11-14 @1715) 	e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL);
> bafef0ae (Jesper Nilsson 2007-11-14  1716) }
> bafef0ae (Jesper Nilsson 2007-11-14  1717) #endif
> bafef0ae (Jesper Nilsson 2007-11-14  1718) 
> ^1da177e (Linus Torvalds 2005-04-16  1719) static int
> ^1da177e (Linus Torvalds 2005-04-16  1720) etrax_init_module(void)
> ^1da177e (Linus Torvalds 2005-04-16  1721) {
> ^1da177e (Linus Torvalds 2005-04-16  1722) 	return etrax_ethernet_init();
> ^1da177e (Linus Torvalds 2005-04-16  1723) }

Thanks!

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com