From: Stephen Hemminger <shemminger@vyatta.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: mlindner@marvell.com, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Thu, 04 Oct 2012 14:44:42 +0000 [thread overview]
Message-ID: <20121004074442.180d8f01@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CA+MoWDp4W5BCA1t_HgEtLhMs1btVTOkbtBytOVtAzJriEZ-16A@mail.gmail.com>
On Thu, 4 Oct 2012 11:05:55 +0200
Peter Senna Tschudin <peter.senna@gmail.com> wrote:
> >
> > Thanks for looking into these kind of problems. The contents
> > of the patch are correct, but the automated commit message is useless.
> > You shouldn't just blindly say what the automated
> > script was looking for, you should describe what the bug is so that evaluators
> > can decide what the impact is and if it should be backported to stable
> > and vendor kernels.
> >
> > Please resubmit the patchs with a reasonable analysis in the commit message.
> > Something like:
> >
> > There is a bug in skge driver. If alloc_etherdev() fails, then
> > skge_devinit() will return NULL, and the skge_probe function incorrectly
> > returns success 0. It should return -ENOMEM instead.
> >
> >
>
> Stephen, I do not want to include function names on the commit
> message. What do you think about this updated message, is it
> acceptable?
>
No still to generic, it needs to be written by a human examining
the file and understanding what the cause and effect of the bug
is.
next prev parent reply other threads:[~2012-10-04 14:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 16:18 [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code Peter Senna Tschudin
2012-10-03 16:25 ` Stephen Hemminger
2012-10-03 18:48 ` David Miller
2012-10-04 9:05 ` Peter Senna Tschudin
2012-10-04 14:44 ` Stephen Hemminger [this message]
2012-10-04 17:32 ` Peter Senna Tschudin
2012-10-04 17:40 ` Stephen Hemminger
2012-10-04 18:13 ` Peter Senna Tschudin
2012-10-04 18:23 ` David Miller
2012-10-04 18:49 ` Peter Senna Tschudin
2012-10-04 18:54 ` David Miller
2012-10-05 0:09 ` Joe Perches
2012-10-05 5:22 ` Julia Lawall
2012-10-05 7:36 ` Joe Perches
2012-10-05 8:02 ` Dan Carpenter
2012-10-05 8:08 ` Julia Lawall
2012-10-10 17:08 ` Peter Senna Tschudin
2012-10-10 17:40 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004074442.180d8f01@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox