* RE: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon
2012-10-04 9:40 [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] Fengguang Wu
@ 2012-10-04 13:13 ` Deucher, Alexander
2012-10-15 11:40 ` Fengguang Wu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Deucher, Alexander @ 2012-10-04 13:13 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
> -----Original Message-----
> From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> Sent: Thursday, October 04, 2012 5:41 AM
> To: Deucher, Alexander
> Cc: kernel-janitors@vger.kernel.org
> Subject: [drm:drm-next 186/301] ERROR:
> "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko]
> undefined!
>
> Hi Alex,
>
> FYI, kernel build failed on
>
> tree: git://people.freedesktop.org/~airlied/linux.git drm-next
> head: 268d28371cd326be4dfcd7eba5917bf4b9d30c8f
> commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301]
> drm/radeon: add get_backlight_level callback
> config: ia64-defconfig
>
> All error/warnings:
>
> ERROR: "radeon_legacy_get_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "atombios_set_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "atombios_get_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "radeon_legacy_set_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko]
> undefined!
Should be fixed with the attached patch.
Alex
[-- Attachment #2: 0001-drm-radeon-fix-compilation-with-backlight-disabled.patch --]
[-- Type: application/octet-stream, Size: 3167 bytes --]
From bfe7cddc85d8bf3af38cfaebbc42f09d1acee268 Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexander.deucher@amd.com>
Date: Thu, 4 Oct 2012 09:10:10 -0400
Subject: [PATCH] drm/radeon: fix compilation with backlight disabled
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/radeon/radeon_acpi.c | 2 +
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 42 +++++++++++-----------
2 files changed, 23 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_acpi.c b/drivers/gpu/drm/radeon/radeon_acpi.c
index faf1ed5..6a4d75a 100644
--- a/drivers/gpu/drm/radeon/radeon_acpi.c
+++ b/drivers/gpu/drm/radeon/radeon_acpi.c
@@ -372,6 +372,7 @@ int radeon_atif_handler(struct radeon_device *rdev,
radeon_set_backlight_level(rdev, enc, req.backlight_level);
+#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
if (rdev->is_atom_bios) {
struct radeon_encoder_atom_dig *dig = enc->enc_priv;
backlight_force_update(dig->bl_dev,
@@ -381,6 +382,7 @@ int radeon_atif_handler(struct radeon_device *rdev,
backlight_force_update(dig->bl_dev,
BACKLIGHT_UPDATE_HOTKEY);
}
+#endif
}
}
/* TODO: check other events */
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index 8ad9c5f..c5690de 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -269,27 +269,6 @@ static const struct drm_encoder_helper_funcs radeon_legacy_lvds_helper_funcs = {
.disable = radeon_legacy_encoder_disable,
};
-#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
-
-static uint8_t radeon_legacy_lvds_level(struct backlight_device *bd)
-{
- struct radeon_backlight_privdata *pdata = bl_get_data(bd);
- uint8_t level;
-
- /* Convert brightness to hardware level */
- if (bd->props.brightness < 0)
- level = 0;
- else if (bd->props.brightness > RADEON_MAX_BL_LEVEL)
- level = RADEON_MAX_BL_LEVEL;
- else
- level = bd->props.brightness;
-
- if (pdata->negative)
- level = RADEON_MAX_BL_LEVEL - level;
-
- return level;
-}
-
u8
radeon_legacy_get_backlight_level(struct radeon_encoder *radeon_encoder)
{
@@ -331,6 +310,27 @@ radeon_legacy_set_backlight_level(struct radeon_encoder *radeon_encoder, u8 leve
radeon_legacy_lvds_update(&radeon_encoder->base, dpms_mode);
}
+#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
+
+static uint8_t radeon_legacy_lvds_level(struct backlight_device *bd)
+{
+ struct radeon_backlight_privdata *pdata = bl_get_data(bd);
+ uint8_t level;
+
+ /* Convert brightness to hardware level */
+ if (bd->props.brightness < 0)
+ level = 0;
+ else if (bd->props.brightness > RADEON_MAX_BL_LEVEL)
+ level = RADEON_MAX_BL_LEVEL;
+ else
+ level = bd->props.brightness;
+
+ if (pdata->negative)
+ level = RADEON_MAX_BL_LEVEL - level;
+
+ return level;
+}
+
static int radeon_legacy_backlight_update_status(struct backlight_device *bd)
{
struct radeon_backlight_privdata *pdata = bl_get_data(bd);
--
1.7.7.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon
2012-10-04 9:40 [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] Fengguang Wu
2012-10-04 13:13 ` [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon Deucher, Alexander
@ 2012-10-15 11:40 ` Fengguang Wu
2012-10-15 12:55 ` Deucher, Alexander
2012-10-15 13:00 ` Fengguang Wu
3 siblings, 0 replies; 5+ messages in thread
From: Fengguang Wu @ 2012-10-15 11:40 UTC (permalink / raw)
To: kernel-janitors
ping
On Thu, Oct 04, 2012 at 05:40:41PM +0800, Fengguang Wu wrote:
> Hi Alex,
>
> FYI, kernel build failed on
>
> tree: git://people.freedesktop.org/~airlied/linux.git drm-next
> head: 268d28371cd326be4dfcd7eba5917bf4b9d30c8f
> commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301] drm/radeon: add get_backlight_level callback
> config: ia64-defconfig
>
> All error/warnings:
>
> ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "atombios_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "atombios_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "radeon_legacy_set_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] undefined!
> ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko] undefined!
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon
2012-10-04 9:40 [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] Fengguang Wu
2012-10-04 13:13 ` [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon Deucher, Alexander
2012-10-15 11:40 ` Fengguang Wu
@ 2012-10-15 12:55 ` Deucher, Alexander
2012-10-15 13:00 ` Fengguang Wu
3 siblings, 0 replies; 5+ messages in thread
From: Deucher, Alexander @ 2012-10-15 12:55 UTC (permalink / raw)
To: kernel-janitors
> -----Original Message-----
> From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> Sent: Monday, October 15, 2012 7:41 AM
> To: Deucher, Alexander
> Cc: kernel-janitors@vger.kernel.org; Peter Hüwe
> Subject: Re: [drm:drm-next 186/301] ERROR:
> "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko]
> undefined!
>
> ping
The fix is in my patch queue, but I was out of town last week. I'll send the pull request to Dave this week.
Alex
>
> On Thu, Oct 04, 2012 at 05:40:41PM +0800, Fengguang Wu wrote:
> > Hi Alex,
> >
> > FYI, kernel build failed on
> >
> > tree: git://people.freedesktop.org/~airlied/linux.git drm-next
> > head: 268d28371cd326be4dfcd7eba5917bf4b9d30c8f
> > commit: 6d92f81dcf2d40b8ebb947bba5435642b830f649 [186/301]
> drm/radeon: add get_backlight_level callback
> > config: ia64-defconfig
> >
> > All error/warnings:
> >
> > ERROR: "radeon_legacy_get_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> > ERROR: "atombios_set_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> > ERROR: "atombios_get_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> > ERROR: "radeon_legacy_set_backlight_level"
> [drivers/gpu/drm/radeon/radeon.ko] undefined!
> > ERROR: "backlight_force_update" [drivers/gpu/drm/radeon/radeon.ko]
> undefined!
> >
> > ---
> > 0-DAY kernel build testing backend Open Source Technology Center
> > Fengguang Wu, Yuanhan Liu Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon
2012-10-04 9:40 [drm:drm-next 186/301] ERROR: "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko] Fengguang Wu
` (2 preceding siblings ...)
2012-10-15 12:55 ` Deucher, Alexander
@ 2012-10-15 13:00 ` Fengguang Wu
3 siblings, 0 replies; 5+ messages in thread
From: Fengguang Wu @ 2012-10-15 13:00 UTC (permalink / raw)
To: kernel-janitors
On Mon, Oct 15, 2012 at 12:55:47PM +0000, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: Fengguang Wu [mailto:fengguang.wu@intel.com]
> > Sent: Monday, October 15, 2012 7:41 AM
> > To: Deucher, Alexander
> > Cc: kernel-janitors@vger.kernel.org; Peter Hüwe
> > Subject: Re: [drm:drm-next 186/301] ERROR:
> > "radeon_legacy_get_backlight_level" [drivers/gpu/drm/radeon/radeon.ko]
> > undefined!
> >
> > ping
>
> The fix is in my patch queue, but I was out of town last week. I'll send the pull request to Dave this week.
OK, thank you!
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread