From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 04 Oct 2012 18:43:01 +0000 Subject: Re: [patch 3/3] brcmfmac: Using zero instead of NULL Message-Id: <20121004184301.GP13767@mwanda> List-Id: References: <20121003060713.GC3802@elgon.mountain> <506DB904.9000002@broadcom.com> In-Reply-To: <506DB904.9000002@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arend van Spriel Cc: Brett Rudley , Roland Vossen , "Franky (Zhenhui) Lin" , Kan Yan , "John W. Linville" , Hante Meuleman , Pieter-Paul Giesberts , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, kernel-janitors@vger.kernel.org On Thu, Oct 04, 2012 at 06:27:48PM +0200, Arend van Spriel wrote: > On 10/03/2012 08:07 AM, Dan Carpenter wrote: > >Sparse complains that we use zero instead of NULL here. In fact, the > >initialization is wrong and should be removed. Doing these kinds of > >bogus initializations means that GCC can't detect unitialized variables > >and leads to bugs. > > We already had it fixed internally, but your change is more > sensible. I had it reviewed internally and plan to send it to John > for 3.8 (ie. wireless-next after merge window). Let me know if that > is ok with you. Sounds good. regards, dan carpenter