From: Stephen Hemminger <shemminger@vyatta.com>
To: Fengguang Wu <fengguang.wu@intel.com>,
David Miller <davem@davemloft.net>
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] vxlan: fix more sparse warnings
Date: Mon, 08 Oct 2012 21:55:30 +0000 [thread overview]
Message-ID: <20121008145530.54a56962@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20121007123635.GB24374@localhost>
Fix a couple harmless sparse warnings reported by Fengguang Wu.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Later patches will fix the other warnings as a side effect of more substantial
changes.
--- a/drivers/net/vxlan.c 2012-10-08 13:41:36.920210233 -0700
+++ b/drivers/net/vxlan.c 2012-10-08 13:44:05.630729809 -0700
@@ -1084,13 +1084,13 @@ static int vxlan_fill_info(struct sk_buf
if (nla_put_u32(skb, IFLA_VXLAN_ID, vxlan->vni))
goto nla_put_failure;
- if (vxlan->gaddr && nla_put_u32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr))
+ if (vxlan->gaddr && nla_put_be32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr))
goto nla_put_failure;
if (vxlan->link && nla_put_u32(skb, IFLA_VXLAN_LINK, vxlan->link))
goto nla_put_failure;
- if (vxlan->saddr && nla_put_u32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr))
+ if (vxlan->saddr && nla_put_be32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr))
goto nla_put_failure;
if (nla_put_u8(skb, IFLA_VXLAN_TTL, vxlan->ttl) ||
next prev parent reply other threads:[~2012-10-08 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 12:36 drivers/net/vxlan.c:676:53: sparse: incorrect type in argument 5 (different base types) Fengguang Wu
2012-10-08 16:51 ` Stephen Hemminger
2012-10-08 21:55 ` Stephen Hemminger [this message]
2012-10-08 21:58 ` [PATCH] vxlan: fix more sparse warnings David Miller
2012-10-09 8:56 ` drivers/net/vxlan.c:676:53: sparse: incorrect type in argument 5 (different base types) Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008145530.54a56962@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox