From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Sjur BRENDELAND <sjur.brandeland@stericsson.com>,
Fengguang Wu <fengguang.wu@intel.com>,
"Linus Walleij (linus.walleij@linaro.org)"
<linus.walleij@linaro.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [remoteproc:for-next 6/9] remoteproc_virtio.c:(.text+0x238e7e): undefined reference to `vring_tr
Date: Tue, 09 Oct 2012 13:28:47 +0000 [thread overview]
Message-ID: <20121009132847.GC4587@mwanda> (raw)
In-Reply-To: <CAK=WgbaNHBVeF_A0jyNpRvnsO_BbkJGxKzyroC6pO1x+OELe0w@mail.gmail.com>
On Tue, Oct 09, 2012 at 01:52:49PM +0200, Ohad Ben-Cohen wrote:
> Hi Sjur,
>
> On Tue, Oct 9, 2012 at 12:30 PM, Sjur BRENDELAND
> <sjur.brandeland@stericsson.com> wrote:
> > Sorry for not responding sooner, but I thought this issue was solved with
> > your patch "remoteproc: fix (again) the virtio-related build breakage"
> > (https://lkml.org/lkml/2012/10/6/85).
> >
> > I'm not sure I understand why you would want to add a dependency to ARM.
> > But if you're uncomfortable by having STE_MODEM_RPROC directly selectable,
> > perhaps we could let it be selected by arch specific Kconfig files, e.g. mach-ux500?
>
> I would just like the Kconfig dependencies to reflect the "real world":
>
> E.g., if there's no chance the STE modem is going to be used on x86,
> then let's not ask x86 folks about it.
>
> Does limiting the STE modem to certain platform/architectures make
> sense ? (if not, that's ok)
>
Unless there is a good reason why then we shouldn't put arbitrary
limits like that. If we leave it in people at least run static
analyzers on it and try modprobing it.
regards,
dan carpenter
next prev parent reply other threads:[~2012-10-09 13:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 2:45 [remoteproc:for-next 6/9] remoteproc_virtio.c:(.text+0x238e7e): undefined reference to `vring_transp Fengguang Wu
2012-10-02 8:24 ` [remoteproc:for-next 6/9] remoteproc_virtio.c:(.text+0x238e7e): undefined reference to `vring_tr Ohad Ben-Cohen
2012-10-09 9:56 ` Ohad Ben-Cohen
2012-10-09 10:30 ` Sjur BRENDELAND
2012-10-09 11:52 ` Ohad Ben-Cohen
2012-10-09 13:28 ` Dan Carpenter [this message]
2012-10-09 14:15 ` Ohad Ben-Cohen
2012-10-09 14:26 ` Dan Carpenter
2012-10-09 14:38 ` Ohad Ben-Cohen
2012-10-11 18:49 ` Sjur BRENDELAND
2012-10-11 21:08 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009132847.GC4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox