From: Jean Delvare <khali@linux-fr.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Ryan Mallon <rmallon@gmail.com>, Antti Palosaari <crope@iki.fi>,
kernel-janitors@vger.kernel.org, shubhrajyoti@ti.com,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization
Date: Tue, 09 Oct 2012 12:12:20 +0000 [thread overview]
Message-ID: <20121009141220.412c15c8@endymion.delvare> (raw)
In-Reply-To: <alpine.DEB.2.02.1210080722470.1972@localhost6.localdomain6>
Hi Julia,
On Mon, 8 Oct 2012 07:24:11 +0200 (CEST), Julia Lawall wrote:
> > Sorry, I mean either:
> >
> > I2C_MSG_WRITE(priv->cfg->i2c_address, ®, sizeof(reg)),
> > I2C_MSG_READ(priv->cfg->i2c_address, val, sizeof(*val)),
>
> Of course. Sorry for not having seen that. I can do that.
Eek, no, you can't, not in the general case at least. sizeof(*val) will
return the size of the _first_ element of the destination buffer, which
has nothing to do with the length of that buffer (which in turn might
be rightfully longer than the read length for this specific message.)
--
Jean Delvare
next prev parent reply other threads:[~2012-10-09 12:12 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 15:38 [PATCH 0/11] introduce macros for i2c_msg initialization Julia Lawall
2012-10-07 15:38 ` [PATCH 13/13] drivers/media/tuners/e4000.c: use " Julia Lawall
2012-10-07 16:33 ` walter harms
2012-10-07 16:44 ` Julia Lawall
2012-10-07 17:13 ` walter harms
2012-10-07 17:18 ` Julia Lawall
2012-10-07 18:16 ` Joe Perches
2012-10-07 18:56 ` Julia Lawall
2012-10-07 21:39 ` Joe Perches
2012-10-07 21:43 ` Julia Lawall
2012-10-07 21:51 ` Joe Perches
2012-10-08 1:56 ` Mauro Carvalho Chehab
2012-10-08 2:11 ` Ryan Mallon
2012-10-08 7:54 ` Antti Palosaari
2012-10-08 8:31 ` Julia Lawall
2012-10-09 23:32 ` Mauro Carvalho Chehab
[not found] ` <20121009203238.63d2275f-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2012-10-11 6:45 ` Julia Lawall
2012-12-18 11:46 ` Jean Delvare
[not found] ` <20121218124640.5b1e7176-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-12-18 12:36 ` Julia Lawall
2012-12-18 13:13 ` Wolfram Sang
2012-10-08 5:04 ` Julia Lawall
2012-10-07 21:49 ` Ryan Mallon
2012-10-07 21:52 ` Ryan Mallon
2012-10-07 15:38 ` [PATCH 2/13] drivers/media/tuners/mxl5007t.c: " Julia Lawall
2012-10-09 12:30 ` Jean Delvare
2012-10-09 12:50 ` Julia Lawall
2012-10-07 15:38 ` [PATCH 3/13] drivers/media/tuners/qt1010.c: " Julia Lawall
2012-10-07 21:55 ` Ryan Mallon
2012-10-08 5:05 ` Julia Lawall
2012-10-08 5:13 ` Ryan Mallon
2012-10-08 5:24 ` Julia Lawall
2012-10-09 12:12 ` Jean Delvare [this message]
2012-10-09 12:51 ` Julia Lawall
2012-10-07 15:38 ` [PATCH 4/13] drivers/media/tuners/tda18212.c: " Julia Lawall
2012-10-07 15:38 ` [PATCH 5/13] drivers/media/tuners: " Julia Lawall
2012-10-07 22:05 ` Ryan Mallon
2012-10-08 5:12 ` Julia Lawall
2012-10-07 15:38 ` [PATCH 6/13] drivers/media/tuners/tda18271-common.c: " Julia Lawall
2012-10-07 15:38 ` [PATCH 7/13] drivers/media/tuners/tua9001.c: " Julia Lawall
2012-10-07 15:38 ` [PATCH 8/13] drivers/media/tuners/fc2580.c: " Julia Lawall
2012-10-07 15:38 ` [PATCH 9/13] drivers/media/tuners/fc0011.c: " Julia Lawall
2012-10-07 16:43 ` walter harms
2012-10-07 16:50 ` Julia Lawall
2012-10-07 16:54 ` walter harms
2012-10-07 18:05 ` Michael Büsch
2012-10-09 12:06 ` Jean Delvare
2012-10-07 15:38 ` [PATCH 10/13] drivers/media/tuners/tda8290.c: " Julia Lawall
2012-10-07 15:38 ` [PATCH 11/13] drivers/media/tuners/tda18218.c: " Julia Lawall
2012-10-07 15:38 ` [PATCH 12/13] drivers/media/tuners/max2165.c: " Julia Lawall
2012-10-07 22:14 ` Ryan Mallon
2012-10-08 5:13 ` Julia Lawall
[not found] ` <1349624323-15584-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2012-10-07 15:38 ` [PATCH 1/13] include/linux/i2c.h: introduce " Julia Lawall
2012-10-09 15:32 ` [PATCH 0/11] " Jean Delvare
[not found] ` <20121009173237.7c1a49e9-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-09 15:43 ` Julia Lawall
2012-10-22 9:18 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009141220.412c15c8@endymion.delvare \
--to=khali@linux-fr.org \
--cc=crope@iki.fi \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=rmallon@gmail.com \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox