From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [glommer-memcg:kmemcg-slab 26/33] drivers/firmware/memmap.c:240:19: error: conflicting types for
Date: Mon, 15 Oct 2012 11:17:33 +0000 [thread overview]
Message-ID: <20121015111733.GA12946@localhost> (raw)
In-Reply-To: <20121015024230.GA16122@localhost>
On Mon, Oct 15, 2012 at 12:39:39PM +0400, Glauber Costa wrote:
> On 10/15/2012 06:42 AM, Fengguang Wu wrote:
> > Hi Glauber,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git kmemcg-slab
> > head: f7dc2a43ce771e73443c82eb25d95f72f8161b45
> > commit: d17ddfd35a7329643b2fb442ade58e2974a2a05c [26/33] sl[au]b: Allocate objects from memcg cache
> > config: ia64-allmodconfig # make ARCH=ia64 allmodconfig
> > branch date: 3 hours ago
> > commit date: 4 hours ago
> >
>
> totally unrelated to my tree.
It's not your fault, but perhaps not totally unrelated ;-)
Your commit seems like the direct cause for:
drivers/firmware/memmap.c:240:19: error: conflicting types for 'memmap_init'
arch/ia64/include/asm/pgtable.h:565:17: note: previous declaration of 'memmap_init' was here
It adds
+#include <linux/memcontrol.h>
+#include <linux/mm.h>
to slub_def.h, this makes firmware/memmap.c eventually include
arch/ia64/include/asm/pgtable.h to create the type conflict.
The suggested fix, however, is to rename firmware/memmap.c's local
memmap_init() to a more specific name.
Thanks,
Fengguang
> Bad commit is :
>
> commit 69ac9cd629ca96e59f34eb4ccd12d00b2c8276a7
> Author: Bernhard Walle <bwalle@suse.de>
> Date: Fri Jun 27 13:12:54 2008 +0200
>
> sysfs: add /sys/firmware/memmap
prev parent reply other threads:[~2012-10-15 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 2:42 [glommer-memcg:kmemcg-slab 26/33] drivers/firmware/memmap.c:240:19: error: conflicting types for 'me Fengguang Wu
2012-10-15 8:39 ` [glommer-memcg:kmemcg-slab 26/33] drivers/firmware/memmap.c:240:19: error: conflicting types for Glauber Costa
2012-10-15 11:17 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015111733.GA12946@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox